chore(docker): bump flex docker to php8.5#628
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the OpenEMR “flex” Docker image to default to PHP 8.5, aligning the build-time PHP version selection with the existing versioned configuration layout.
Changes:
- Bump the default
PHP_VERSIONbuild arg from 8.4 to 8.5. - Update the inline example for the abbreviated version (
PHP_VERSION_ABBR) to reflect 8.5 → 85.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This change won't get what you want, but good to do.
|
| php${PHP_VERSION_ABBR}-pecl-imagick \ | ||
| php${PHP_VERSION_ABBR}-phar \ | ||
| php${PHP_VERSION_ABBR}-redis \ | ||
| "$(if [ "${PHP_VERSION}" = "8.5" ]; then echo php${PHP_VERSION_ABBR}-pecl-redis; else echo php${PHP_VERSION_ABBR}-redis; fi)" \ |
There was a problem hiding this comment.
rec making this future proof by flipping this (so don;t need to refix for php 8.6)
ie if 8.2, 8.3, 8.4 then redis else pecl-redis
There was a problem hiding this comment.
unless this is just a temporary fix for only 8.5
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docker/openemr/flex/Dockerfile:122
- The conditional package arguments for
php${PHP_VERSION_ABBR}-jsonandphp${PHP_VERSION_ABBR}-opcacheare wrapped in quotes. When the condition is false (e.g., PHP 8.5), this expands to an empty-string argument, andapk addwill fail trying to install a package named "". Remove the quotes around the command substitution (so empty output disappears), or restructure the RUN step to append these packages conditionally without producing empty args.
"$(if [ "${PHP_VERSION}" = "8.2" ] || [ "${PHP_VERSION}" = "8.3" ] || [ "${PHP_VERSION}" = "8.4" ]; then echo php${PHP_VERSION_ABBR}-json; fi)" \
php${PHP_VERSION_ABBR}-ldap \
php${PHP_VERSION_ABBR}-mbstring \
php${PHP_VERSION_ABBR}-mysqli \
"$(if [ "${PHP_VERSION}" = "8.2" ] || [ "${PHP_VERSION}" = "8.3" ] || [ "${PHP_VERSION}" = "8.4" ]; then echo php${PHP_VERSION_ABBR}-opcache; fi)" \
php${PHP_VERSION_ABBR}-openssl \
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
time for alpine 3.23 :) |
|
|
) ## Summary - Pin all CI docker-compose images to their current `@sha256:` digests, including shared compose files (mailpit, dev-nginx, selenium) and inferno - Move `compose-shared-mailpit.yml` and `compose-shared-nginx.yml` into their own directories so Dependabot can discover them - Fix `parse_docker_dir.sh` to strip `@sha256:` suffixes before splitting image references (prevents noisy matrix names) - Reorder `COMPOSE_FILE` so the first entry is always directly in `ci/` (required for correct relative path resolution) - Add Dependabot `docker-compose` entries covering all CI directories This prevents silent CI breakage when an upstream image is rebuilt under the same tag. The recent Alpine 3.22→3.23 bump in `dev-php-fpm:8.5` (openemr/openemr-devops#628) changed Node.js from 22 to 24, causing an ABI mismatch in `libxmljs2` that broke `CcdaServiceDocumentRequestorTest::testSocket_get`. With digest pinning, that image change would have arrived as a Dependabot PR where CI would have caught the failure before merge. ## Test plan - [x] All CI workflows pass with pinned digests - [ ] Dependabot creates PRs when images are rebuilt (observable after merge)
|
(below completed at: openemr/openemr#11495 ) |
Fixes #
Short description of what this resolves:
Changes proposed in this pull request: