chore(ci): upload test functionality artifacts#636
chore(ci): upload test functionality artifacts#636stephenwaite merged 2 commits intoopenemr:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the container functionality CI workflow to retain test output for later inspection, and modernizes the runner image used by the jobs.
Changes:
- Switches the functionality test jobs from
ubuntu-22.04toubuntu-24.04. - Uploads
utilities/container_benchmarking/test_results/as a GitHub Actions artifact for each job (retained for 7 days), even when the tests fail.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: test-results-810 | ||
| path: utilities/container_benchmarking/test_results/ | ||
| retention-days: 7 |
There was a problem hiding this comment.
This workflow uses actions/upload-artifact@v4, but the repo’s other workflows are already on actions/upload-artifact@v7 (e.g. build-810.yml). Consider bumping to v7 here as well to stay consistent and pick up the latest fixes/features.
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: test-results-binary | ||
| path: utilities/container_benchmarking/test_results/ | ||
| retention-days: 7 |
There was a problem hiding this comment.
This workflow uses actions/upload-artifact@v4, but the repo’s other workflows are already on actions/upload-artifact@v7 (e.g. build-810.yml). Consider bumping to v7 here as well to stay consistent and pick up the latest fixes/features.
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: test-results-flex | ||
| path: utilities/container_benchmarking/test_results/ | ||
| retention-days: 7 |
There was a problem hiding this comment.
This workflow uses actions/upload-artifact@v4, but the repo’s other workflows are already on actions/upload-artifact@v7 (e.g. build-810.yml). Consider bumping to v7 here as well to stay consistent and pick up the latest fixes/features.
There was a problem hiding this comment.
(If you don't do that in this PR, dependabot will open a PR right after you merge it.)
Fixes #
Short description of what this resolves:
stores artifacts so can examine fail details
Changes proposed in this pull request: