Skip to content

ci(release): switch token mint to client-id var #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kojiromike merged 2 commits into from
May 14, 2026
Merged

ci(release): switch token mint to client-id var #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
277601d
ci(release): switch token mint to client-id var
kojiromike May 14, 2026
a8ccdd7
ci(release): bump create-github-app-token v1 to v3.1
kojiromike May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-patch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
id: app-token
uses: actions/create-github-app-token@v3.1
with:
client-id: ${{ secrets.RELEASE_APP_ID }}
client-id: ${{ vars.RELEASE_APP_CLIENT_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
owner: openemr
repositories: openemr
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
id: app-token
uses: actions/create-github-app-token@v3.1
with:
client-id: ${{ secrets.RELEASE_APP_ID }}
client-id: ${{ vars.RELEASE_APP_CLIENT_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
owner: openemr
repositories: openemr
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/release-permissions-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: Release Permissions Check

# Manual probe of the release App's installed permissions on this repo.
# Mints an App token from RELEASE_APP_ID + RELEASE_APP_PRIVATE_KEY and
# Mints an App token from the RELEASE_APP_CLIENT_ID org variable +
# RELEASE_APP_PRIVATE_KEY org secret and
# exercises only what tools/release/ rotation needs (per docs/release-automation-plan.md).
# Run after installing the App and after secrets rotations.

Expand Down Expand Up @@ -32,9 +33,9 @@ jobs:

- name: Mint release App token
id: app-token
uses: actions/create-github-app-token@v1
uses: actions/create-github-app-token@v3.1
with:
app-id: ${{ secrets.RELEASE_APP_ID }}
client-id: ${{ vars.RELEASE_APP_CLIENT_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}

- name: Probe — installation includes this repo
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-rotation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ jobs:
steps:
- name: Mint release App token
id: app-token
uses: actions/create-github-app-token@v1
uses: actions/create-github-app-token@v3.1
with:
app-id: ${{ secrets.RELEASE_APP_ID }}
client-id: ${{ vars.RELEASE_APP_CLIENT_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}

- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ship-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ jobs:
steps:
- name: Mint release App token
id: app-token
uses: actions/create-github-app-token@v1
uses: actions/create-github-app-token@v3.1
with:
app-id: ${{ secrets.RELEASE_APP_ID }}
client-id: ${{ vars.RELEASE_APP_CLIENT_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
owner: openemr
repositories: |
Expand Down
3 changes: 2 additions & 1 deletion docs/release-automation-plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ host most of the rewrite logic.
## Permissions self-check

`.github/workflows/release-permissions-check.yml` (manual `workflow_dispatch`).
Mints an App token from `RELEASE_APP_ID` + `RELEASE_APP_PRIVATE_KEY` and
Mints an App token from the `RELEASE_APP_CLIENT_ID` org variable +
`RELEASE_APP_PRIVATE_KEY` org secret and
probes only what this repo's rotation workflow needs:

- `GET /installation/repositories` — confirm this repo is in the install list.
Expand Down