Make /user/register redirect optional#85
Open
claudiu-cristea wants to merge 15 commits into
Open
Conversation
… config is changing.
claudiu-cristea
changed the title
pfrenssen
requested changes
Jun 5, 2019
Member
pfrenssen
left a comment
pfrenssen
left a comment
There was a problem hiding this comment.
Great work! I have some suggestions.
idimopoulos
requested changes
Jun 5, 2019
pfrenssen
approved these changes
Jun 5, 2019
Member
pfrenssen
left a comment
pfrenssen
left a comment
There was a problem hiding this comment.
All points made by me and @idimopoulos are addressed, this looks good!
idimopoulos
approved these changes
Jun 6, 2019
|
@hernani or @imanoleguskiza I think I need the code in here but this pull request has been approved a year ago and is still sitting here... Any plans with this module? |
|
I've tried to revolve the merge conflict in my fork https://github.com/HermanScis/oe_authentication/tree/83-registrer-redirect See #122 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83