Propagate gateway timeouts to dashboard deployment#1252
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The dashboard needs the gateway's upstream_timeout to compare against each function's exec_timeout and warn when the function timeout exceeds the gateway timeout. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
The gateway read and write timeout env variables were not correctly propagated to the dashboard. Values must match for dashboard invoke to work correctly. If the dashboard's timeout is shorter, it can close the connection before the gateway completes the request. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
This comment has been minimized.
This comment has been minimized.
9fee2c1 to
adeedd7
Compare
This comment has been minimized.
This comment has been minimized.
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)9/10. The change is narrowly scoped and consistent with existing chart configuration; only local Helm rendering could not be performed in this environment. Summary per fileSummary per file
Overall AssessmentThe scoped change is low risk. The added dashboard environment variables use existing Helm values with established defaults in Detailed ReviewDetailed ReviewNo blocking findings. The added variables in
The default values are present under AI agent details. |
Description
Propagates three gateway timeout environment variables to the dashboard deployment in the Helm chart:
upstream_timeout- so the dashboard can compare each function'sexec_timeoutagainst the gateway's upstream timeout and show a warning when the function timeout exceeds it.read_timeoutandwrite_timeout- these must match the gateway's values for dashboard invocations to work correctly. If the dashboard's timeouts are shorter, it can close the connection before the gateway completes the request.Why is this needed?
The
upstream_timeoutis required for the gateway timeout warning feature added to the dashboard. Theread_timeoutandwrite_timeoutwere not correctly propagated to the dashboard, which could cause the dashboard to close connections prematurely before the gateway finished handling a request.Who is this for?
What company is this for? Are you listed in the ADOPTERS.md file?
How Has This Been Tested?
Types of changes
Checklist:
git commit -s