Skip to content

Commit 2f9f811

Browse files
committed
feat: addres scomments reduce dupl
1 parent 3987ace commit 2f9f811

1 file changed

Lines changed: 13 additions & 15 deletions

File tree

src/main/java/dev/openfga/sdk/errors/FgaError.java

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -378,9 +378,9 @@ public String getMessage() {
378378
}
379379

380380
/**
381-
* Returns a developer-friendly error message with all context
381+
* Build the core error message (operation + message + code)
382382
*/
383-
public String getDetailedMessage() {
383+
private String buildCoreMessage() {
384384
StringBuilder sb = new StringBuilder();
385385

386386
if (operationName != null) {
@@ -393,6 +393,15 @@ public String getDetailedMessage() {
393393
sb.append(super.getMessage());
394394
}
395395

396+
return sb.toString();
397+
}
398+
399+
/**
400+
* Returns a developer-friendly error message with all context
401+
*/
402+
public String getDetailedMessage() {
403+
StringBuilder sb = new StringBuilder(buildCoreMessage());
404+
396405
if (apiErrorCode != null) {
397406
sb.append(" (code: ").append(apiErrorCode).append(")");
398407
}
@@ -414,19 +423,8 @@ public String getDetailedMessage() {
414423
@Override
415424
public String toString() {
416425
StringBuilder sb = new StringBuilder();
417-
sb.append(getClass().getSimpleName());
418-
419-
if (operationName != null) {
420-
sb.append(" [").append(operationName).append("]");
421-
}
422-
423-
sb.append(": ");
424-
425-
if (apiErrorMessage != null) {
426-
sb.append(apiErrorMessage);
427-
} else if (super.getMessage() != null) {
428-
sb.append(super.getMessage());
429-
}
426+
sb.append(getClass().getSimpleName()).append(": ");
427+
sb.append(buildCoreMessage());
430428

431429
if (getStatusCode() > 0) {
432430
sb.append(" (HTTP ").append(getStatusCode()).append(")");

0 commit comments

Comments
 (0)