chore: cleanup tests, remove unused method, move urlEncode method#165
Merged
jimmyjames merged 1 commit intomainfrom May 6, 2025
Merged
chore: cleanup tests, remove unused method, move urlEncode method#165jimmyjames merged 1 commit intomainfrom
jimmyjames merged 1 commit intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=========================================
Coverage 33.42% 33.42%
- Complexity 991 994 +3
=========================================
Files 182 182
Lines 6902 6878 -24
Branches 771 772 +1
=========================================
- Hits 2307 2299 -8
+ Misses 4488 4476 -12
+ Partials 107 103 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhamzeh
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync changes from generator to SDK for test cleanup and removal of unused method.
Description
StringUtil, deprecate it inApiClient(chore(java-sdk): cleanup tests sdk-generator#525) Thanks @piotrooo!ApiClient#valueToString(removed unused function valueToString sdk-generator#541) Thanks @AlessandroMinoccheri!References
Review Checklist
main