fix: promote Jackson dependencies to api scope in published POM#350
fix: promote Jackson dependencies to api scope in published POM#350curfew-marathon wants to merge 1 commit into
Conversation
Jackson core, annotations, and databind are used in the public API surface (model class annotations, ApiClient imports), so they must be declared as `api` rather than `implementation`. This ensures downstream Maven consumers have them on the compile classpath and avoids "unknown enum constant" compiler warnings. Switches the Gradle plugin from `java` to `java-library` to enable the `api` configuration. Fixes #349
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe build file switches the Java plugin from ChangesJackson API Export Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (38.48%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
============================================
+ Coverage 38.47% 38.48% +0.01%
- Complexity 1267 1268 +1
============================================
Files 198 198
Lines 7704 7704
Branches 900 900
============================================
+ Hits 2964 2965 +1
Misses 4591 4591
+ Partials 149 148 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
javatojava-libraryto enable theapidependency configurationjackson-core,jackson-annotations, andjackson-databindfromimplementationtoapiso they appear ascompilescope in the published Maven POMjackson-datatype-jsr310andjackson-databind-nullableremainimplementationas they don't appear in the public API surfaceWhy
These Jackson types are used in public model class annotations and
ApiClientimports. Declaring them asimplementationmaps toruntimescope in Maven, meaning downstream Maven consumers don't have them on their compile classpath — causingunknown enum constantcompiler warnings.Fixes #349
Summary by CodeRabbit