refactor: implement AI feedback

Author: evansims

config/clients/dotnet/CHANGELOG.md.mustache

@@ -7,7 +7,7 @@
   - per-request headers support via `Headers` property on all client options classes
   - `IRequestOptions` interface and `RequestOptions` class for API-level header support
   - `IClientRequestOptions` interface and `ClientRequestOptions` class for client-level header support
-  - add header validation to prevent overiding of reserved headers
+  - add header validation to prevent overriding of reserved headers
 - feat: add write conflict resolution options
   - `ConflictOptions` to control behavior for duplicate writes and missing deletes
   - `OnDuplicateWrites` option: `Error` (default) or `Ignore` for handling duplicate tuple writes

config/clients/dotnet/template/OpenFgaClientTests.mustache

@@ -2571,6 +2571,7 @@ public class {{appShortName}}ClientTests : IDisposable {
     [Fact]
     public async Task WriteTuples_WithConflictOptions_ShouldPassOptionToApi() {
         WriteRequest? capturedRequest = null;
+        HttpResponseMessage? responseMsg = null;
         var mockHandler = new Mock<HttpMessageHandler>(MockBehavior.Strict);
         mockHandler.Protected()
             .Setup<Task<HttpResponseMessage>>(
@@ -2580,9 +2581,12 @@ public class {{appShortName}}ClientTests : IDisposable {
                     req.Method == HttpMethod.Post),
                 ItExpr.IsAny<CancellationToken>()
             )
-            .ReturnsAsync(new HttpResponseMessage() {
-                StatusCode = HttpStatusCode.OK,
-                Content = Utils.CreateJsonStringContent(new Object()),
+            .ReturnsAsync(() => {
+                responseMsg = new HttpResponseMessage() {
+                    StatusCode = HttpStatusCode.OK,
+                    Content = Utils.CreateJsonStringContent(new Object()),
+                };
+                return responseMsg;
             })
             .Callback<HttpRequestMessage, CancellationToken>((req, _) => {
                 var content = req.Content!.ReadAsStringAsync().Result;
@@ -2600,16 +2604,24 @@ public class {{appShortName}}ClientTests : IDisposable {
             }
         };
 
-        await fgaClient.WriteTuples(tuples, new ClientWriteOptions {
-            AuthorizationModelId = "01GXSA8YR785C4FYS3C0RTG7B1",
-            Conflict = new ConflictOptions {
-                OnDuplicateWrites = OnDuplicateWrites.Ignore
-            }
-        });
+        try
+        {
+            await fgaClient.WriteTuples(tuples, new ClientWriteOptions {
+                AuthorizationModelId = "01GXSA8YR785C4FYS3C0RTG7B1",
+                Conflict = new ConflictOptions {
+                    OnDuplicateWrites = OnDuplicateWrites.Ignore
+                }
+            });
 
-        Assert.NotNull(capturedRequest);
-        Assert.NotNull(capturedRequest.Writes);
-        Assert.Equal(WriteRequestWrites.OnDuplicateEnum.Ignore, capturedRequest.Writes.OnDuplicate);
+            Assert.NotNull(capturedRequest);
+            Assert.NotNull(capturedRequest.Writes);
+            Assert.Equal(WriteRequestWrites.OnDuplicateEnum.Ignore, capturedRequest.Writes.OnDuplicate);
+        }
+        finally
+        {
+            if (responseMsg != null)
+                responseMsg.Dispose();
+        }
     }
 
     /// <summary>
@@ -2618,6 +2630,7 @@ public class {{appShortName}}ClientTests : IDisposable {
     [Fact]
     public async Task DeleteTuples_WithConflictOptions_ShouldPassOptionToApi() {
         WriteRequest? capturedRequest = null;
+        HttpResponseMessage? httpResponse = null;
         var mockHandler = new Mock<HttpMessageHandler>(MockBehavior.Strict);
         mockHandler.Protected()
             .Setup<Task<HttpResponseMessage>>(
@@ -2627,9 +2640,12 @@ public class {{appShortName}}ClientTests : IDisposable {
                     req.Method == HttpMethod.Post),
                 ItExpr.IsAny<CancellationToken>()
             )
-            .ReturnsAsync(new HttpResponseMessage() {
-                StatusCode = HttpStatusCode.OK,
-                Content = Utils.CreateJsonStringContent(new Object()),
+            .ReturnsAsync(() => {
+                httpResponse = new HttpResponseMessage() {
+                    StatusCode = HttpStatusCode.OK,
+                    Content = Utils.CreateJsonStringContent(new Object()),
+                };
+                return httpResponse;
             })
             .Callback<HttpRequestMessage, CancellationToken>((req, _) => {
                 var content = req.Content!.ReadAsStringAsync().Result;
@@ -2657,6 +2673,8 @@ public class {{appShortName}}ClientTests : IDisposable {
         Assert.NotNull(capturedRequest);
         Assert.NotNull(capturedRequest.Deletes);
         Assert.Equal(WriteRequestDeletes.OnMissingEnum.Ignore, capturedRequest.Deletes.OnMissing);
+
+        httpResponse?.Dispose();
     }
 
     /// <summary>