Performance: cache paramsQl for HYBRID KeySwitchDown (implements TODO)#1184
Closed
amneeksingh wants to merge 3 commits intomainfrom
Closed
Performance: cache paramsQl for HYBRID KeySwitchDown (implements TODO)#1184amneeksingh wants to merge 3 commits intomainfrom
amneeksingh wants to merge 3 commits intomainfrom
Conversation
…int8_t and removed their aliases from inttypes.h (#1168) * Remove usshort and uschar from inttypes.h and replaced their usage with uint16_t and uint8_t * Removed usint from inttypes.h and replaced its usage with uint32_t * Pass integer parameter by value to function instead of by constant reference --------- Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
Added funding acknowledgment for ARPA-H research.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the TODO in keyswitch-hybrid.cpp to avoid rebuilding paramsQl on every call in the HYBRID keyswitch path.
Background:
KeySwitchDown and KeySwitchDownFirstElement currently reconstruct paramsQl (ILDCRTParams for the first sizeQl towers of Q) from paramsQlP on every call, allocating vectors and a new ILDCRTParams. This runs in a hot path during relinearization and ApproxModDown.
Changes:
Notes:
Files changed:
Happy to add a regression test or benchmark comparison if that would help the review.