Skip to content

Commit 81abfac

Browse files
authored
Increase resilience of web API tests
2 parents cd8e6f3 + ac98bd9 commit 81abfac

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
.venv
12
.project
23
.spyderproject
34
.pydevproject

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@ This package contains the core features of OpenFisca, which are meant to be used
1717

1818
OpenFisca runs on Python 3.7. More recent versions should work, but are not tested.
1919

20-
2120
## Installation
2221

23-
If you're developping your own country package, you don't need to explicitly install OpenFisca-Core. It just needs to appear [in your package dependencies](https://github.com/openfisca/openfisca-france/blob/18.2.1/setup.py#L53).
22+
If you're developing your own country package, you don't need to explicitly install OpenFisca-Core. It just needs to appear [in your package dependencies](https://github.com/openfisca/openfisca-france/blob/18.2.1/setup.py#L53).
2423

2524
If you want to contribute to OpenFisca-Core itself, welcome! To install it locally in development mode run the following commands:
2625

tests/web_api/test_variables.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,9 @@ def test_variable_formula_github_link():
9494

9595

9696
def test_variable_formula_content():
97-
formula_code = "def formula(person, period, parameters):\n \"\"\"\n Income tax.\n\n The formula to compute the income tax for a given person at a given period\n \"\"\"\n return person(\"salary\", period) * parameters(period).taxes.income_tax_rate\n"
98-
assert variable['formulas']['0001-01-01']['content'] == formula_code
97+
content = variable['formulas']['0001-01-01']['content']
98+
assert "def formula(person, period, parameters):" in content
99+
assert "return person(\"salary\", period) * parameters(period).taxes.income_tax_rate" in content
99100

100101

101102
def test_null_values_are_dropped():
@@ -157,4 +158,6 @@ def test_variable_documentation():
157158
variable = json.loads(response.data.decode('utf-8'))
158159
assert variable['documentation'] == "This allowance was introduced on the 1st of Jan 1980.\nIt disappeared in Dec 2016."
159160

160-
assert variable['formulas']['1980-01-01']['documentation'] == "\nHousing allowance.\n\nThis allowance was introduced on the 1st of Jan 1980.\nCalculating it before this date will always return the variable default value, 0.\n\nTo compute this allowance, the 'rent' value must be provided for the same month,\nbut 'housing_occupancy_status' is not necessary.\n"
161+
formula_documentation = variable['formulas']['1980-01-01']['documentation']
162+
assert "Housing allowance." in formula_documentation
163+
assert "Calculating it before this date will always return the variable default value, 0." in formula_documentation

0 commit comments

Comments
 (0)