Modularise test_trace.py

Author: RamParameswaran

tests/web_api/test_trace.py

@@ -1,23 +1,19 @@
-# -*- coding: utf-8 -*-
-
+import copy
+import dpath
+from http import client
 import json
-from copy import deepcopy
 
-from http.client import OK
-import dpath
 from openfisca_country_template.situation_examples import single, couple
 
-from . import subject
-
 
 def assert_items_equal(x, y):
     assert set(x) == set(y)
 
 
-def test_trace_basic():
+def test_trace_basic(test_client):
     simulation_json = json.dumps(single)
-    response = subject.post('/trace', data = simulation_json, content_type = 'application/json')
-    assert response.status_code == OK
+    response = test_client.post('/trace', data = simulation_json, content_type = 'application/json')
+    assert response.status_code == client.OK
     response_json = json.loads(response.data.decode('utf-8'))
     disposable_income_value = dpath.util.get(response_json, 'trace/disposable_income<2017-01>/value')
     assert isinstance(disposable_income_value, list)
@@ -31,52 +27,52 @@ def test_trace_basic():
     assert_items_equal(basic_income_dep, ['age<2017-01>'])
 
 
-def test_trace_enums():
-    new_single = deepcopy(single)
+def test_trace_enums(test_client):
+    new_single = copy.deepcopy(single)
     new_single['households']['_']['housing_occupancy_status'] = {"2017-01": None}
     simulation_json = json.dumps(new_single)
-    response = subject.post('/trace', data = simulation_json, content_type = 'application/json')
+    response = test_client.post('/trace', data = simulation_json, content_type = 'application/json')
     response_json = json.loads(response.data)
     housing_status = dpath.util.get(response_json, 'trace/housing_occupancy_status<2017-01>/value')
     assert housing_status[0] == 'tenant'  # The default value
 
 
-def test_entities_description():
+def test_entities_description(test_client):
     simulation_json = json.dumps(couple)
-    response = subject.post('/trace', data = simulation_json, content_type = 'application/json')
+    response = test_client.post('/trace', data = simulation_json, content_type = 'application/json')
     response_json = json.loads(response.data.decode('utf-8'))
     assert_items_equal(
         dpath.util.get(response_json, 'entitiesDescription/persons'),
         ['Javier', "Alicia"]
         )
 
 
-def test_root_nodes():
+def test_root_nodes(test_client):
     simulation_json = json.dumps(couple)
-    response = subject.post('/trace', data = simulation_json, content_type = 'application/json')
+    response = test_client.post('/trace', data = simulation_json, content_type = 'application/json')
     response_json = json.loads(response.data.decode('utf-8'))
     assert_items_equal(
         dpath.util.get(response_json, 'requestedCalculations'),
         ['disposable_income<2017-01>', 'total_benefits<2017-01>', 'total_taxes<2017-01>']
         )
 
 
-def test_str_variable():
-    new_couple = deepcopy(couple)
+def test_str_variable(test_client):
+    new_couple = copy.deepcopy(couple)
     new_couple['households']['_']['postal_code'] = {'2017-01': None}
     simulation_json = json.dumps(new_couple)
 
-    response = subject.post('/trace', data = simulation_json, content_type = 'application/json')
+    response = test_client.post('/trace', data = simulation_json, content_type = 'application/json')
 
-    assert response.status_code == OK
+    assert response.status_code == client.OK
 
 
-def test_trace_parameters():
-    new_couple = deepcopy(couple)
+def test_trace_parameters(test_client):
+    new_couple = copy.deepcopy(couple)
     new_couple['households']['_']['housing_tax'] = {'2017': None}
     simulation_json = json.dumps(new_couple)
 
-    response = subject.post('/trace', data = simulation_json, content_type = 'application/json')
+    response = test_client.post('/trace', data = simulation_json, content_type = 'application/json')
     response_json = json.loads(response.data.decode('utf-8'))
 
     assert len(dpath.util.get(response_json, 'trace/housing_tax<2017>/parameters')) > 0