Skip to content

Commit c2e9a5e

Browse files
author
Mauko Quiroga
committed
Fix typing: use NoReturn
1 parent fb9cca8 commit c2e9a5e

1 file changed

Lines changed: 16 additions & 5 deletions

File tree

.circleci/get-numpy-version.py

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,34 @@
11
#! /usr/bin/env python
22

3+
import os
34
import sys
5+
import typing
46
from packaging import version
7+
from typing import NoReturn, Union
58

69
import numpy
710

11+
if typing.TYPE_CHECKING:
12+
from packaging.version import LegacyVersion, Version
813

9-
def prev() -> str:
10-
major, minor, _ = _installed().release
14+
15+
def prev() -> NoReturn:
16+
release = _installed().release
17+
18+
if release is None:
19+
sys.exit(os.EX_DATAERR)
20+
21+
major, minor, _ = release
1122

1223
if minor == 0:
13-
exit(1)
24+
sys.exit(os.EX_DATAERR)
1425

1526
minor -= 1
1627
print(f"{major}.{minor}.0") # noqa: T001
17-
exit()
28+
sys.exit(os.EX_OK)
1829

1930

20-
def _installed() -> version:
31+
def _installed() -> Union[LegacyVersion, Version]:
2132
return version.parse(numpy.__version__)
2233

2334

0 commit comments

Comments
 (0)