Skip to content

Fix InYamlTestReform typing and clarify YAML parameter replacement#1373

Open
benjello wants to merge 6 commits intomasterfrom
vk/f5e8-1359-suggestion
Open

Fix InYamlTestReform typing and clarify YAML parameter replacement#1373
benjello wants to merge 6 commits intomasterfrom
vk/f5e8-1359-suggestion

Conversation

@benjello
Copy link
Copy Markdown
Member

Summary

This PR fixes the YAML test reform typing issue and clarifies behavior, then updates project metadata accordingly.

What changed

  • Fix constructor signature:
    • replace with a typed optional dict and safe default initialization
  • Clarify docstring behavior:
    • YAML test replaces the full parameter tree
  • Bump package version in :
    • -> (patch bump, non-breaking bugfix)
  • Update with a entry referencing Suggestion de Claude que l'on gagnerait à regarder #1359
  • Add/extend repository guidance so future agents consistently:
    • use for Python commands
    • open a PR after commits
    • apply version bump + changelog updates for functional changes

Why

sets a default value to the class object instead of expressing a type hint. This is ambiguous and error-prone. The new signature is explicit and safer.

Validation

  • Result:

Compatibility

  • No breaking API change expected.
  • This is a patch-level release change.

Copy link
Copy Markdown
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do NOT merge any PR until the codebase revert that has been described in our community space or equivalent has been implemented (copied below for reference), otherwise this will bring back the behaviour that had to be yanked:

I believe we should revert the codebase to 8d26af3, i.e. align it with the 44.2.2  version that is the one currently published on Pypi, with:

  1. A revert commit.
  2. An update of the CHANGELOG to mention yanked versions
  3. A version bump to 44.6.0 to restore continuous deployment capabilities.

Comment thread AGENTS.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants