Merged
Conversation
bonjourmauko
approved these changes
Mar 23, 2021
Member
|
Thanks ! |
augusto-herrmann
approved these changes
Mar 23, 2021
Member
augusto-herrmann
left a comment
There was a problem hiding this comment.
I believe this is good practice. I believe minor changes in wording of the texts should not cause the tests to fail.
9cf28b0 to
ac4faf2
Compare
Member
Author
|
Using this PR as a knight for a typo in README and a minor gitignore change to decrease administrative costs. |
| ## Installation | ||
|
|
||
| If you're developping your own country package, you don't need to explicitly install OpenFisca-Core. It just needs to appear [in your package dependencies](https://github.com/openfisca/openfisca-france/blob/18.2.1/setup.py#L53). | ||
| If you're developing your own country package, you don't need to explicitly install OpenFisca-Core. It just needs to appear [in your package dependencies](https://github.com/openfisca/openfisca-france/blob/18.2.1/setup.py#L53). |
RamParameswaran
added a commit
that referenced
this pull request
Apr 1, 2021
…ariable_formula_content`
RamParameswaran
added a commit
that referenced
this pull request
Apr 15, 2021
…ariable_formula_content`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical changes
Supersedes #986, re-implements #981, would have avoided #980.