Skip to content

Remove spurious logging#764

Merged
lilyminium merged 1 commit into
mainfrom
fix-763
Apr 7, 2026
Merged

Remove spurious logging#764
lilyminium merged 1 commit into
mainfrom
fix-763

Conversation

@lilyminium
Copy link
Copy Markdown
Contributor

Fixes #763 by switching to _apply

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.28%. Comparing base (c50a7b7) to head (fc572bb).
⚠️ Report is 1 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lilyminium lilyminium marked this pull request as ready for review April 7, 2026 14:11
Copy link
Copy Markdown
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (ideally if you did a live test of this behavior locally?)

@lilyminium
Copy link
Copy Markdown
Contributor Author

Thanks! Yes I did, logs look much more sane:

2026-04-07 16:23:45,606 - openff.evaluator.datasets.curation.workflow - INFO - Applying SelectSubstances
2026-04-07 16:48:06,610 - openff.evaluator.datasets.curation.components.components - INFO - 14540 data points were removed after applying the SelectSubstances component.
2026-04-07 16:48:06,611 - openff.evaluator.datasets.curation.workflow - INFO - SelectSubstances applied

@lilyminium lilyminium merged commit 89ee2bf into main Apr 7, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too much logging for SelectSubstances

2 participants