Update dask#768
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
mattwthompson
approved these changes
Apr 9, 2026
Member
mattwthompson
left a comment
mattwthompson
left a comment
There was a problem hiding this comment.
This is grey but the changes look good based on a quick comparison between logs. Let me know if there are more changes you are aiming to get it and I'm happy to re-review
Here are the links I use (which probably won't last long:
- https://productionresultssa2.blob.core.windows.net/actions-results/979fd388-206a-46d8-9771-95bdec5b932c/workflow-job-run-531114ac-6242-53ca-ba54-61bbbe06b2fc/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-04-09T11%3A25%3A23Z&sig=I0vvQVw2kKTnMfzkzoDzDyypOrWhO%2F3A%2FwFTbqQ5vfk%3D&ske=2026-04-09T14%3A37%3A54Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-04-09T10%3A37%3A54Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-04-09T11%3A15%3A18Z&sv=2025-11-05
- https://productionresultssa4.blob.core.windows.net/actions-results/c554afcc-367f-41e2-89f3-e609d430aa26/workflow-job-run-5b0a4b42-d764-5ed0-afd5-a4cd3659bcbf/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-04-09T11%3A24%3A08Z&sig=3Bxnl%2BYQU03X7AcqUmqJOVzYbCneJmBSnywEix27LZY%3D&ske=2026-04-09T14%3A37%3A54Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-04-09T10%3A37%3A54Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-04-09T11%3A14%3A03Z&sv=2025-11-05
Contributor
Author
|
Thanks Matt! No this is all I was thinking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #767
I just scrolled https://github.com/dask/dask-jobqueue/blob/55b972741f2cb0a8a9702637d335f89e5345c7af/dask_jobqueue/core.py#L196-L352 and found these two kwargs that need updating. I'm not sure if there are tests for this.