Fix compatibility with Pydantic 2.13#1501
Draft
mattwthompson wants to merge 5 commits into
Draft
Conversation
Member
Author
|
De-serialization of collections is failing by not picking up non-default values. The fix is probably straightforward but I don't have more time to work on this today |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 94.07% 94.07%
=======================================
Files 73 73
Lines 6055 6058 +3
=======================================
+ Hits 5696 5699 +3
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Failure is at a serialization time, not de-serialization In [32]: state1.collections['Electrostatics'].scale_14
Out[32]: 0.8333333333
In [33]: with open("test.json", "w") as f:
...: f.write(state1.model_dump_json())
...:
In [34]: json.loads(open('test.json').read())['collections']['Electrostatics'].keys()
Out[34]: dict_keys(['type', 'is_plugin', 'expression', 'key_map', 'potentials'])
In [35]: json.loads(open('test.json').read())['collections']['Electrostatics']['scale_14']
---------------------------------------------------------------------------
KeyError Traceback (most recent call last)
Cell In[35], line 1
----> 1 json.loads(open('test.json').read())['collections']['Electrostatics']['scale_14']
KeyError: 'scale_14' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Possible fix for #1346
Checklist