Skip to content

[DNM] Allow "experimental-auto" idivf#1823

Closed
mattwthompson wants to merge 1 commit into
mainfrom
experimental-idivf-auto
Closed

[DNM] Allow "experimental-auto" idivf#1823
mattwthompson wants to merge 1 commit into
mainfrom
experimental-idivf-auto

Conversation

@mattwthompson

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.48%. Comparing base (5ffcb58) to head (ef6a695).
⚠️ Report is 190 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-wags j-wags left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me and I saw a presentation from @ntBre this morning using this experimental functionality, so I assume there aren't glaring errors. IIRC, this is the first time that we're introducing an indexed parameter that could be int or string. I'd approve this pending adding tests that ensure setters and getters do sane things, including being set to int/string while being accessed both as parameter.idivf[N] and parameter.idivfN.

@mattwthompson

Copy link
Copy Markdown
Member Author

Closing until we start working on this again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants