Skip to content

ofxAssimp Naming Convention#8367

Merged
NickHardeman merged 7 commits intoopenframeworks:masterfrom
NickHardeman:assimp-namespace
Mar 11, 2025
Merged

ofxAssimp Naming Convention#8367
NickHardeman merged 7 commits intoopenframeworks:masterfrom
NickHardeman:assimp-namespace

Conversation

@NickHardeman
Copy link
Copy Markdown
Contributor

  • Reduce naming complexity from ofx::assimp to ofxAssimp.
  • Changed ofx::assimp::Model to ofxAssimp::Scene for better representation of functionality and more closely aligned to the underlying assimp scene.
  • Updated legacy c import api calls to newer c++ importer.
  • Added ofxAssimp.h file for importing the ofxAssimpScene file.
  • Updated ofxAssimp examples to reflect changes.

Further discussion here: #8354

@NickHardeman NickHardeman changed the title Assimp Naming Convention ofxAssimp Naming Convention Mar 10, 2025
@ofTheo
Copy link
Copy Markdown
Member

ofTheo commented Mar 11, 2025

Looks good to me @NickHardeman
Merge when your ready :)

@NickHardeman NickHardeman merged commit 37eb57b into openframeworks:master Mar 11, 2025
15 checks passed
@NickHardeman NickHardeman deleted the assimp-namespace branch March 11, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants