Skip to content

Update sidebar flag #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giswqs merged 2 commits into from
Nov 15, 2025
+13 −2
Merged

Update sidebar flag #1265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f3e9ba
Update sidebar flag
giswqs Nov 15, 2025
8b96d0c
Fix type hints
giswqs Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions leafmap/maplibregl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ def __init__(
},
projection: str = "mercator",
use_message_queue: bool = None,
add_sidebar: bool = False,
add_floating_sidebar: bool = True,
add_sidebar: Optional[bool] = None,
add_floating_sidebar: Optional[bool] = None,
sidebar_visible: bool = False,
sidebar_width: int = 360,
sidebar_args: Optional[Dict] = None,
Expand Down Expand Up @@ -260,6 +260,17 @@ def __init__(
]
)

if add_sidebar is None and add_floating_sidebar is None:
add_sidebar = False
add_floating_sidebar = True
elif add_sidebar:
add_floating_sidebar = False
elif add_floating_sidebar:
add_sidebar = False
Comment on lines +266 to +269

Copilot AI Nov 15, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional logic doesn't handle the case where both add_sidebar and add_floating_sidebar are explicitly set to True by the user. When both are True, both elif branches execute sequentially, resulting in both being set to False, which is likely unintended. Consider adding validation to prevent conflicting parameters or handle this case explicitly.

Copilot uses AI. Check for mistakes.
else:
add_sidebar = False
add_floating_sidebar = False

if sidebar_args is None:
sidebar_args = {}
if "sidebar_visible" not in sidebar_args:
Expand Down