Skip to content

Fix add-data bug#1267

Merged
giswqs merged 1 commit into
masterfrom
add-data
Nov 16, 2025
Merged

Fix add-data bug#1267
giswqs merged 1 commit into
masterfrom
add-data

Conversation

@giswqs

@giswqs giswqs commented Nov 16, 2025

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings November 16, 2025 17:34
@giswqs giswqs merged commit ca8a7c3 into master Nov 16, 2025
18 checks passed
@giswqs giswqs deleted the add-data branch November 16, 2025 17:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the classify function where pandas would issue SettingWithCopyWarning when modifying user-provided dataframes. The fix adds a defensive copy of the input data to prevent unintended modifications to the original data.

  • Added .copy() call to create a defensive copy of user-provided pandas/geopandas data structures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request November 16, 2025 17:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants