Skip to content

Fix fire module bugs and update development status classifier #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giswqs merged 2 commits into from
Jan 31, 2026
Merged

Fix fire module bugs and update development status classifier #1292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11ec64a
Fix fire module bugs and update development status classifier
giswqs Jan 31, 2026
43c3b35
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions leafmap/fire.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,9 @@ def _apply_client_filters(
if gdf.empty:
return gdf

mask = [True] * len(gdf)
import pandas as pd

mask = pd.Series(True, index=gdf.index)

if farea_min is not None and "farea" in gdf.columns:
mask = mask & (gdf["farea"] >= farea_min)
Expand Down Expand Up @@ -353,6 +355,7 @@ def fire_gdf_from_place(
farea_min: Optional[float] = None,
farea_max: Optional[float] = None,
duration_min: Optional[float] = None,
duration_max: Optional[float] = None,
meanfrp_min: Optional[float] = None,
limit: int = 1000,
buffer_dist: Optional[float] = None,
Expand All @@ -368,6 +371,7 @@ def fire_gdf_from_place(
farea_min: Minimum fire area in km².
farea_max: Maximum fire area in km².
duration_min: Minimum fire duration in days.
duration_max: Maximum fire duration in days.
meanfrp_min: Minimum mean Fire Radiative Power.
limit: Maximum number of features to return.
buffer_dist: Distance to buffer around the place geometry, in meters.
Expand All @@ -385,11 +389,9 @@ def fire_gdf_from_place(
"""
try:
import geopandas as gpd
from shapely.geometry import box
except ImportError:
raise ImportError(
"geopandas and shapely are required. "
"Install with: pip install geopandas shapely"
"geopandas is required. " "Install with: pip install geopandas"
)

try:
Expand Down Expand Up @@ -423,6 +425,7 @@ def fire_gdf_from_place(
farea_min=farea_min,
farea_max=farea_max,
duration_min=duration_min,
duration_max=duration_max,
meanfrp_min=meanfrp_min,
limit=limit,
)
Expand Down Expand Up @@ -560,6 +563,7 @@ def search_fires(
farea_min=farea_min,
farea_max=farea_max,
duration_min=duration_min,
duration_max=duration_max,
meanfrp_min=meanfrp_min,
limit=limit,
)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ requires-python = ">=3.9"
license = {text = "MIT license"}
keywords = ["leafmap"]
classifiers = [
"Development Status :: 2 - Pre-Alpha",
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
"License :: OSI Approved :: MIT License",
"Natural Language :: English",
Expand Down