Chris little temporal crs 1#223
Open
chris-little wants to merge 6 commits into
Open
Conversation
Added Temporal CRS to definition of Temporal Reference Systems.
Added example for Temporal Coordinate Reference System with JSON representation.
Improved clarity in the description of geospatial coordinate reference systems and possible datums. Added examples for geographic and projected CRSs.
Corrected typos and improved clarity in the documentation regarding temporal reference systems.
Updated URLs to use HTTPS and corrected hyphenation in text.
m-burgoyne
reviewed
Jun 29, 2026
Comment on lines
386
to
+387
| - The object MAY have an `"id"` member, whose value MUST be a string and SHOULD be a common identifier for the reference system. | ||
| - The object MAY have a `"datum"` member if the identified reference system definition does not specify a datum. |
Collaborator
There was a problem hiding this comment.
Would it be more appropriate to use SHOULD in cases where the reference system does not specify a datum?
m-burgoyne
reviewed
Jun 29, 2026
|
|
||
| - The value of the `"type"` member MUST be "VerticalCRS" | ||
| - The object MAY have an `"id"` member, whose value MUST be a string and SHOULD be a common identifier for the reference system. | ||
| - The object MAY have a `"datum"` member if the identified reference system definition does not specify a datum. |
Collaborator
There was a problem hiding this comment.
Would it be more appropriate to use SHOULD in cases where the reference system does not specify a datum?
m-burgoyne
reviewed
Jun 29, 2026
|
|
||
| The value of the `"type"` member MUST be "TemporalCRS" | ||
| - The object MAY have an `"id"` member, whose value MUST be a string and SHOULD be a common identifier for the reference system. | ||
| - The object MAY have a `"datum"` member if the identified Temporal Coordinate Reference System definition does not specify a datum. |
Collaborator
There was a problem hiding this comment.
Would it be more appropriate to use SHOULD in cases where the reference system does not specify a datum?
m-burgoyne
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add text describing the use of
datumsfor all CRSs