fix: fix: replace deprecated stdlib cgi usage with stdlib email

A commonly recommended replacement for the deprecated cgi package in PEP594. Using an email Message object to parse an HTTP header is a little hacky, but since HTTP's Content-Disposition syntax was derived from MIME, they're compatible enough in practice

Author: spwoodcock

qfieldcloud_sdk/sdk.py

@@ -5,12 +5,12 @@
 import sys
 import requests
 import urllib3
-import cgi
 
 from enum import Enum
 from pathlib import Path
 from typing import Any, Callable, Dict, List, Optional, TypedDict, Union, cast
 from urllib import parse as urlparse
+from email.message import Message
 
 from requests.adapters import HTTPAdapter, Retry
 from requests_toolbelt.multipart.encoder import MultipartEncoderMonitor
@@ -456,8 +456,7 @@ def get_project_seed_xlsform(
 
             return None
 
-        _value, params = cgi.parse_header(content_disposition)
-        filename = params.get("filename")
+        filename = self._get_filename_from_content_disposition(content_disposition)
 
         if not filename:
             logger.warning(
@@ -471,6 +470,14 @@ def get_project_seed_xlsform(
 
         return str(path)
 
+    @staticmethod
+    def _get_filename_from_content_disposition(
+        content_disposition: str,
+    ) -> Optional[str]:
+        message = Message()
+        message["Content-Disposition"] = content_disposition
+        return cast(Optional[str], message.get_filename())
+
     def list_remote_files(
         self, project_id: str, skip_metadata: bool = True
     ) -> List[Dict[str, Any]]:

tests/test_cli_client.py

@@ -21,6 +21,17 @@ def test_paginated_list_projects_include_public(self):
         )
         self.assertTrue(0 < len(results) and len(results) <= 50)
 
+    def test_parse_content_disposition_filename(self):
+        filename = Client._get_filename_from_content_disposition(
+            'attachment; filename="seed.xlsx"'
+        )
+        self.assertEqual(filename, "seed.xlsx")
+
+        encoded_filename = Client._get_filename_from_content_disposition(
+            "attachment; filename*=UTF-8''my%20seed.xlsx"
+        )
+        self.assertEqual(encoded_filename, "my seed.xlsx")
+
 
 class TestCLI(unittest.TestCase):
     @classmethod