Removing unnecessary try/except blocks

Author: SeqLaz

qfieldcloud_sdk/cli.py

@@ -468,19 +468,12 @@ def delta_push(ctx: Context, project_id: str, delta_filename: str) -> None:
     """Push a delta file to a project with PROJECT_ID."""
     log(f'Pushing delta file "{delta_filename}" to project "{project_id}"…')
 
-    try:
-        response = ctx.obj["client"].push_delta(project_id, delta_filename)
+    response = ctx.obj["client"].push_delta(project_id, delta_filename)
 
-        if ctx.obj["format_json"]:
-            print_json(response)
-        else:
-            log(f'Delta file "{delta_filename}" pushed to project "{project_id}".')
-    except Exception as e:
-        log(f"Error pushing delta file: {e}")
-        if ctx.obj["format_json"]:
-            print_json({"error": str(e)})
-        else:
-            click.echo(f"Error: {e}", err=True)
+    if ctx.obj["format_json"]:
+        print_json(response)
+    else:
+        log(f'Delta file "{delta_filename}" pushed to project "{project_id}".')
 
 
 @cli.command()

qfieldcloud_sdk/sdk.py

@@ -183,6 +183,20 @@ def is_empty(self) -> bool:
         return self.limit is None and self.offset is None
 
 
+class DeltaPushResponse(TypedDict):
+    """Represents the structure of the response for pushing a delta file.
+
+    Attributes:
+        status: The status of the response.
+        message: A message providing additional information about the response.
+        details: Additional details about the delta push operation.
+    """
+
+    status: str
+    message: Optional[str]
+    details: Optional[Dict[str, Any]]
+
+
 class Client:
     """The core component of the QFieldCloud SDK, providing methods for interacting with the QFieldCloud platform.
 
@@ -617,34 +631,25 @@ def job_status(self, job_id: str) -> Dict[str, Any]:
 
         return resp.json()
 
-    def push_delta(self, project_id: str, delta_filename: str) -> Dict[str, Any]:
+    def push_delta(self, project_id: str, delta_filename: str) -> DeltaPushResponse:
         """Push a delta file to a project.
 
         Args:
             project_id: Project ID.
             delta_filename: Path to the delta JSON file.
 
         Returns:
-            A dictionary containing the response from the server.
+            A DeltaPushResponse containing the response from the server.
         """
-        try:
-            with open(delta_filename, "r") as delta_file:
-                files = {"file": delta_file}
-                resp = self._request(
-                    "POST",
-                    f"deltas/{project_id}/",
-                    files={
-                      "file": delta_file
-                    },
-                )
-            print(f"Response status code: {resp.status_code}")
+        with open(delta_filename, "r") as delta_file:
+            files = {"file": delta_file}
+            response = self._request(
+                "POST",
+                f"deltas/{project_id}/",
+                files=files,
+            )
 
-            if resp.content:
-                return resp.json()
-            else:
-                return {"message": "Delta pushed successfully"}
-        except Exception as e:
-            raise RuntimeError(f"Failed to push delta: {e}")
+        return cast(DeltaPushResponse, response)
 
     def delete_files(
         self,