Skip to content

Commit aa7ff8c

Browse files
committed
Set a single FileTransferStatus
1 parent 53b3604 commit aa7ff8c

2 files changed

Lines changed: 14 additions & 26 deletions

File tree

src/bin/qfieldcloud-cli

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,8 @@ def download_files(ctx, project_id, local_dir, filter_glob, throw_on_error):
294294
if files:
295295
count = 0
296296
for file in files:
297-
if file["status"] == sdk.DownloadStatus.FAILED:
298-
log(f'{file["name"]} - failed to download.')
297+
if file.get("error"):
298+
log(f'File "{file["name"]}" failed to download: {file["error"]} .')
299299
else:
300300
count += 1
301301

src/qfieldcloud_sdk/sdk.py

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,7 @@
2020
__version__ = metadata.version("qfieldcloud_sdk")
2121

2222

23-
class DownloadStatus(str, Enum):
24-
PENDING = "PENDING"
25-
SUCCESS = "SUCCESS"
26-
FAILED = "FAILED"
27-
28-
29-
class UploadStatus(str, Enum):
30-
PENDING = "PENDING"
31-
SUCCESS = "SUCCESS"
32-
FAILED = "FAILED"
33-
34-
35-
class DeleteStatus(str, Enum):
23+
class FileTransferStatus(str, Enum):
3624
PENDING = "PENDING"
3725
SUCCESS = "SUCCESS"
3826
FAILED = "FAILED"
@@ -201,9 +189,9 @@ def upload_files(
201189
show_progress,
202190
job_id,
203191
)
204-
file["status"] = UploadStatus.SUCCESS
192+
file["status"] = FileTransferStatus.SUCCESS
205193
except Exception as err:
206-
file["status"] = UploadStatus.FAILED
194+
file["status"] = FileTransferStatus.FAILED
207195
file["error"] = err
208196

209197
if throw_on_error:
@@ -359,7 +347,7 @@ def delete_files(
359347
# file has already been matched by a previous glob pattern
360348
continue
361349

362-
file["status"] = DeleteStatus.PENDING
350+
file["status"] = FileTransferStatus.PENDING
363351
glob_results[glob_pattern].append(file)
364352

365353
for glob_pattern, files in glob_results.items():
@@ -374,15 +362,15 @@ def delete_files(
374362
f'files/{project_id}/{file["name"]}',
375363
stream=True,
376364
)
377-
file["status"] = DeleteStatus.SUCCESS
365+
file["status"] = FileTransferStatus.SUCCESS
378366
except QfcRequestException as err:
379367
resp = err.response
380368

381369
logging.info(
382370
f"{resp.request.method} {resp.url} got HTTP {resp.status_code}"
383371
)
384372

385-
file["status"] = DeleteStatus.FAILED
373+
file["status"] = FileTransferStatus.FAILED
386374
file["error"] = err
387375

388376
self._log(
@@ -403,9 +391,9 @@ def delete_files(
403391
for file in files:
404392
self._log(f'{file["status"]}\t{file["name"]}')
405393

406-
if file["status"] == DeleteStatus.SUCCESS:
394+
if file["status"] == FileTransferStatus.SUCCESS:
407395
files_deleted += 1
408-
elif file["status"] == DeleteStatus.SUCCESS:
396+
elif file["status"] == FileTransferStatus.SUCCESS:
409397
files_failed += 1
410398

411399
self._log(
@@ -488,7 +476,7 @@ def download_files(
488476

489477
for file in files:
490478
if fnmatch.fnmatch(file["name"], filter_glob):
491-
file["status"] = DownloadStatus.PENDING
479+
file["status"] = FileTransferStatus.PENDING
492480
files_to_download.append(file)
493481

494482
for file in files_to_download:
@@ -502,15 +490,15 @@ def download_files(
502490
file["name"],
503491
show_progress,
504492
)
505-
file["status"] = DownloadStatus.SUCCESS
493+
file["status"] = FileTransferStatus.SUCCESS
506494
except QfcRequestException as err:
507495
resp = err.response
508496

509497
logging.info(
510498
f"{resp.request.method} {resp.url} got HTTP {resp.status_code}"
511499
)
512500

513-
file["status"] = DownloadStatus.FAILED
501+
file["status"] = FileTransferStatus.FAILED
514502
file["error"] = err
515503

516504
if throw_on_error:
@@ -597,7 +585,7 @@ def get_files_list(self, root_path: str, filter_glob: str) -> List[Dict[str, Any
597585
files.append(
598586
{
599587
"name": str(path),
600-
"status": UploadStatus.PENDING,
588+
"status": FileTransferStatus.PENDING,
601589
"error": None,
602590
}
603591
)

0 commit comments

Comments
 (0)