Skip to content

Commit e39df96

Browse files
authored
Merge pull request #102 from opengisch/feat/merge-session-environment-settings-before-send
feat: merge session's environment settings before sending request
2 parents f75370f + ddabbfc commit e39df96

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

qfieldcloud_sdk/sdk.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1937,16 +1937,26 @@ def _request(
19371937
request = QfcRequest(**request_params)
19381938

19391939
session_params = {
1940-
"stream": stream,
1941-
"verify": self.verify_ssl,
19421940
# redirects from POST requests automagically turn into GET requests, so better forbid redirects
19431941
"allow_redirects": allow_redirects,
19441942
}
19451943

19461944
if os.environ.get("ENVIRONMENT") == "test":
19471945
return request.mock_response()
19481946
else:
1949-
response = self.session.send(request.prepare(), **session_params)
1947+
prepared_request = self.session.prepare_request(request)
1948+
1949+
# Merge environment settings into session
1950+
settings = self.session.merge_environment_settings(
1951+
url=prepared_request.url,
1952+
proxies={},
1953+
stream=stream,
1954+
verify=self.verify_ssl,
1955+
cert=None,
1956+
)
1957+
settings = settings | session_params # type: ignore
1958+
1959+
response = self.session.send(request.prepare(), **settings)
19501960

19511961
try:
19521962
response.raise_for_status()

0 commit comments

Comments
 (0)