docs & test-suite: shellcheck lint the get_source.sh scripts

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
(cherry picked from commit 095a8f3)

Author: martin-g

components/admin/docs/SOURCES/get_source.sh

@@ -1,31 +1,33 @@
 #!/usr/bin/env bash
 
+set -xe
+
 # Note: The current working directory is the component's SPEC folder
 
 # The folder that will contain the .git/ and docs/ folders
-DOCS_OHPC_FOLDER=docs-ohpc
+DOCS_OHPC_FOLDER="docs-ohpc"
 # A folder that contains the full Git history of the project
 # Full history is needed for the usage of `git archive` command
 COMPLETE_OHPC_FOLDER=$(mktemp -d)
 
 cleanup() {
-    rm -rf ${DOCS_OHPC_FOLDER} ${COMPLETE_OHPC_FOLDER}
+    rm -rf "${DOCS_OHPC_FOLDER}" "${COMPLETE_OHPC_FOLDER}"
 }
 trap cleanup EXIT
 
 # 1. Prepare
 cleanup
-mkdir -p ${DOCS_OHPC_FOLDER}
+mkdir -p "${DOCS_OHPC_FOLDER}"
 
 # 2. Fetch the full Git history so that `git describe` works later
-git clone https://github.com/openhpc/ohpc ${COMPLETE_OHPC_FOLDER}
-cp -r ${COMPLETE_OHPC_FOLDER}/.git ${DOCS_OHPC_FOLDER}
+git clone https://github.com/openhpc/ohpc "${COMPLETE_OHPC_FOLDER}"
+cp -r "${COMPLETE_OHPC_FOLDER}/.git" "${DOCS_OHPC_FOLDER}"
 
 # 3. Copy the local docs/
-cp -r ../../../../docs ${DOCS_OHPC_FOLDER}
+cp -r ../../../../docs "${DOCS_OHPC_FOLDER}"
 
 # 4. Create docs-ohpc.tar
-tar cf ../SOURCES/docs-ohpc.tar ${DOCS_OHPC_FOLDER}
+tar cf ../SOURCES/docs-ohpc.tar "${DOCS_OHPC_FOLDER}"
 
 # 5. Cleanup
 cleanup

components/admin/test-suite/SOURCES/get_source.sh

@@ -9,16 +9,16 @@ OHPC_ROOT_FOLDER="../../../.."
 TESTS_OHPC_FOLDER=tests-ohpc
 
 cleanup() {
-    rm -rf ${TESTS_OHPC_FOLDER}
+    rm -rf "${TESTS_OHPC_FOLDER}"
 }
 trap cleanup EXIT
 
 # 1. Prepare
 cleanup
-mkdir -p ${TESTS_OHPC_FOLDER}
+mkdir -p "${TESTS_OHPC_FOLDER}"
 
 # 2. Copy the local docs/
-cp -r ${OHPC_ROOT_FOLDER}/tests ${TESTS_OHPC_FOLDER}
+cp -r "${OHPC_ROOT_FOLDER}/tests" "${TESTS_OHPC_FOLDER}"
 
 # 3. Create tests-ohpc.tar
-tar cf ../SOURCES/tests-ohpc.tar ${TESTS_OHPC_FOLDER}
+tar cf ../SOURCES/tests-ohpc.tar "${TESTS_OHPC_FOLDER}"

tests/ci/Makefile

@@ -45,6 +45,8 @@ shellcheck-lint:
 		../../misc/shell-functions \
 		../../tests/ci/prepare-ci-environment.sh \
 		../../tests/ci/setup_slurm_and_run_tests.sh \
+		../../components/admin/docs/SOURCES/get_source.sh \
+		../../components/admin/test-suite/SOURCES/get_source.sh \
 		../../tests/libs/netcdf/ohpc-tests/netcdf_all_test_mpi_families \
 		../../tests/libs/netcdf/ohpc-tests/test_mpi_families \
 		../../components/OHPC_setup_mpi \