Skip to content

Merge Charliecloud updates, improve CI, and fix test issues from 4.x#2495

Merged
adrianreber merged 10 commits into
openhpc:3.xfrom
adrianreber:2026-04-26-spack-charliecloud
Apr 27, 2026
Merged

Merge Charliecloud updates, improve CI, and fix test issues from 4.x#2495
adrianreber merged 10 commits into
openhpc:3.xfrom
adrianreber:2026-04-26-spack-charliecloud

Conversation

@adrianreber
Copy link
Copy Markdown
Member

@adrianreber adrianreber commented Apr 26, 2026

No description provided.

@adrianreber
runtimes: merge charliecloud changes from 4.x
d0e1c88 
Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber
dev-tools: update spack to 1.1.1
9cd180f 
- spack: 1.1.0 -> 1.1.1
  upstream: spack/spack

Command: `misc/check_for_package_updates.py -v -o markdown spack
  --update`

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber
tests: fix run_build.py success count and failure messages
12db8d9 
Fix two issues in run_build.py:
- Success count was negative for MPI-dependent packages because it used
  total spec files minus individual build failures
- Failure messages now include compiler/MPI family info for clarity

Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Adrian Reber <areber@redhat.com>
(cherry picked from commit bcbdf16)
@adrianreber
ci: support building multiple spec files in dependency order
8acc753 
When more than one spec file is specified, use misc/build_order.sh
to determine the correct build order via topological sort. After
each spec build, run createrepo_c on the rpmbuild RPMS directory
and register it as a local DNF/zypper repository so that subsequent
builds can resolve dependencies on just-built RPMs.

Also set up the RPM build environment (directories and OHPC_macros)
before invoking build_order.sh, matching the setup used in the
build-order-analysis CI workflow.

Generated with Claude Code (https://claude.ai/code)

Signed-off-by: Adrian Reber <areber@redhat.com>
(cherry picked from commit d132f0c)
@adrianreber
tests: CI and formatting fixes
ff1425d 
- Add setup_slurm_and_run_tests.sh to shfmt lint target
- Apply ruff formatting to run_build.py
- Apply shfmt formatting to setup_slurm_and_run_tests.sh
- Add make distclean step on successful test completion
- Add DISTCLEANFILES to compilers/Makefile.am
- Fix missing newline at end of compilers/Makefile.am

Generated with Claude Code (https://claude.ai/code)

Signed-off-by: Adrian Reber <areber@redhat.com>
(cherry picked from commit c1904aa)
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026 •
edited
Loading

🚀 CCache Statistics

Configuration 🐧 RHEL 🦊 openEuler 🦎 LEAP
🖥️ x86_64 / gnu15 - - -
🖥️ x86_64 / intel - - -
💪 aarch64 / gnu15 - - -
📊 Detailed Statistics

LEAP (aarch64/gnu15)

cache directory                     /github/home/.ccache
primary config                      /github/home/.ccache/ccache.conf
secondary config      (readonly)    /etc/ccache.conf
cache hit (direct)                     0
cache hit (preprocessed)               0
cache miss                             0
cache hit rate                      0.00 %
cleanups performed                     0
files in cache                         0
cache size                           0.0 kB
max cache size                       5.0 GB

LEAP (x86_64/gnu15)

cache directory                     /github/home/.ccache
primary config                      /github/home/.ccache/ccache.conf
secondary config      (readonly)    /etc/ccache.conf
cache hit (direct)                     0
cache hit (preprocessed)               0
cache miss                             0
cache hit rate                      0.00 %
cleanups performed                     0
files in cache                         0
cache size                           0.0 kB
max cache size                       5.0 GB

openEuler (aarch64)

cache directory                     /github/home/.ccache
primary config                      /github/home/.ccache/ccache.conf
secondary config      (readonly)    /etc/ccache.conf
cache hit (direct)                     0
cache hit (preprocessed)               0
cache miss                             0
cache hit rate                      0.00 %
cleanups performed                     0
files in cache                         0
cache size                           0.0 kB
max cache size                       5.0 GB

openEuler (x86_64)

cache directory                     /github/home/.ccache
primary config                      /github/home/.ccache/ccache.conf
secondary config      (readonly)    /etc/ccache.conf
cache hit (direct)                     0
cache hit (preprocessed)               0
cache miss                             0
cache hit rate                      0.00 %
cleanups performed                     0
files in cache                         0
cache size                           0.0 kB
max cache size                       5.0 GB

RHEL (aarch64/gnu15)

Summary:
  Hits:               0 /    0
    Direct:           0 /    0
    Preprocessed:     0 /    0
  Misses:             0
    Direct:           0
    Preprocessed:     0
Primary storage:
  Hits:               0 /    0
  Misses:             0
  Cache size (GB): 0.00 / 5.00 (0.00 %)

Use the -v/--verbose option for more details.

RHEL (x86_64/gnu15)

Summary:
  Hits:               0 /    0
    Direct:           0 /    0
    Preprocessed:     0 /    0
  Misses:             0
    Direct:           0
    Preprocessed:     0
Primary storage:
  Hits:               0 /    0
  Misses:             0
  Cache size (GB): 0.00 / 5.00 (0.00 %)

Use the -v/--verbose option for more details.

RHEL (x86_64/intel)

Summary:
  Hits:               0 /    0
    Direct:           0 /    0
    Preprocessed:     0 /    0
  Misses:             0
    Direct:           0
    Preprocessed:     0
Primary storage:
  Hits:               0 /    0
  Misses:             0
  Cache size (GB): 0.00 / 5.00 (0.00 %)

Use the -v/--verbose option for more details.

🤖 Generated from workflow run 24983337063

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026 •
edited
Loading

Test Results

 31 files  + 4   31 suites  +4   3m 22s ⏱️ + 2m 44s
 58 tests + 5   54 ✅ + 5  4 💤 ±0  0 ❌ ±0 
109 runs  +10  103 ✅ +10  6 💤 ±0  0 ❌ ±0 

Results for commit 1b01187. ± Comparison against base commit 96b2682.

♻️ This comment has been updated with latest results.

@adrianreber
misc: apply 4.x changes
1701b79 
Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber
misc: enhance count_avail_packages.sh from 4.x branch
4dc3346 
Bring enhanced version of count_avail_packages.sh from the 4.x
branch, adapted for 3.x supported OSes (EL_9, Leap_15,
openEuler_22.03). Adds factory mode (-f), debug mode (-d),
markdown table output, glow support, version auto-detection
from git branch, and version validation against OBS/staging.

Generated with Claude Code (https://claude.ai/code)

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber
ci: install createrepo_c for multi rpm builds
b30a32f 
Also python3.11 for leap 15.5. Python 3.6 is too old.

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber adrianreber force-pushed the 2026-04-26-spack-charliecloud branch from 57113a0 to b30a32f Compare April 27, 2026 07:01
@adrianreber
ci: support [TESTS:ALL] marker in PR description
bed1c5a 
Add support for running all tests by including [TESTS:ALL] in the
PR description. When detected, the test jobs will pass ALL to
setup_slurm_and_run_tests.sh instead of the list of changed files.

This applies to both RHEL and openEuler test jobs.

Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Adrian Reber <areber@redhat.com>
(cherry picked from commit 6724af8)
@adrianreber
ci: fix shell injection in check-tests-all action
1b01187 
Pass PR body via env variable instead of inline interpolation
to prevent shell metacharacters (backticks, $(), etc.) in the
PR description from being executed by bash.

Generated with Claude Code (https://claude.ai/code)

Signed-off-by: Adrian Reber <areber@redhat.com>
(cherry picked from commit 80b7598)
@adrianreber adrianreber merged commit 95da08a into openhpc:3.x Apr 27, 2026
27 checks passed
@adrianreber adrianreber deleted the 2026-04-26-spack-charliecloud branch April 27, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adrianreber