Skip to content

add note about naming of IB interface to the documentation on adding nodes using warewulf#2618

Merged
middelkoopt merged 1 commit into
openhpc:4.xfrom
migueldiascosta:update_ipoib_node_docs
Jul 9, 2026
Merged

add note about naming of IB interface to the documentation on adding nodes using warewulf#2618
middelkoopt merged 1 commit into
openhpc:4.xfrom
migueldiascosta:update_ipoib_node_docs

Conversation

@migueldiascosta

@migueldiascosta migueldiascosta commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

addresses #2594

@migueldiascosta migueldiascosta force-pushed the update_ipoib_node_docs branch from e458eb0 to 6a2132b Compare June 19, 2026 13:29
@github-actions

github-actions Bot commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown

🚀 CCache Statistics

Configuration 🐧 RHEL 🦊 openEuler
🖥️ x86_64 / gnu15 🟡 25.94% 🟡 24.35%
🖥️ x86_64 / intel 🟡 27.08% -
💪 aarch64 / gnu15 🔴 17.15% 🔴 15.91%
📊 Detailed Statistics

openEuler (aarch64)

Cacheable calls:    5368 / 9760 (55.00%)
  Hits:              854 / 5368 (15.91%)
    Direct:          435 /  854 (50.94%)
    Preprocessed:    419 /  854 (49.06%)
  Misses:           4514 / 5368 (84.09%)
Uncacheable calls:  4392 / 9760 (45.00%)
Local storage:
  Cache size (GiB):  0.4 /  5.0 ( 7.58%)
  Hits:              854 / 5368 (15.91%)
  Misses:           4514 / 5368 (84.09%)

openEuler (x86_64)

Cacheable calls:    6468 / 11967 (54.05%)
  Hits:             1575 /  6468 (24.35%)
    Direct:          739 /  1575 (46.92%)
    Preprocessed:    836 /  1575 (53.08%)
  Misses:           4893 /  6468 (75.65%)
Uncacheable calls:  5499 / 11967 (45.95%)
Local storage:
  Cache size (GiB):  0.4 /   5.0 ( 8.24%)
  Hits:             1575 /  6468 (24.35%)
  Misses:           4893 /  6468 (75.65%)

RHEL (aarch64/gnu15)

Cacheable calls:    5183 / 9396 (55.16%)
  Hits:              889 / 5183 (17.15%)
    Direct:          469 /  889 (52.76%)
    Preprocessed:    420 /  889 (47.24%)
  Misses:           4294 / 5183 (82.85%)
Uncacheable calls:  4213 / 9396 (44.84%)
Local storage:
  Cache size (GiB):  0.4 /  5.0 ( 7.54%)
  Hits:              889 / 5183 (17.15%)
  Misses:           4294 / 5183 (82.85%)

RHEL (x86_64/gnu15)

Cacheable calls:    6300 / 11628 (54.18%)
  Hits:             1634 /  6300 (25.94%)
    Direct:          797 /  1634 (48.78%)
    Preprocessed:    837 /  1634 (51.22%)
  Misses:           4666 /  6300 (74.06%)
Uncacheable calls:  5328 / 11628 (45.82%)
Local storage:
  Cache size (GiB):  0.4 /   5.0 ( 8.20%)
  Hits:             1634 /  6300 (25.94%)
  Misses:           4666 /  6300 (74.06%)

RHEL (x86_64/intel)

Cacheable calls:     6458 / 17144 (37.67%)
  Hits:              1749 /  6458 (27.08%)
    Direct:           799 /  1749 (45.68%)
    Preprocessed:     950 /  1749 (54.32%)
  Misses:            4709 /  6458 (72.92%)
Uncacheable calls:  10686 / 17144 (62.33%)
Local storage:
  Cache size (GiB):   0.4 /   5.0 ( 7.02%)
  Hits:              1749 /  6458 (27.08%)
  Misses:            4709 /  6458 (72.92%)

🤖 Generated from workflow run 29045356513

@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown

Test Results

 29 files  ±0  29 suites  ±0   46s ⏱️ ±0s
 59 tests ±0  53 ✅ ±0  6 💤 ±0  0 ❌ ±0 
105 runs  ±0  97 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 6a2132b. ± Comparison against base commit b215427.

@adrianreber adrianreber requested a review from middelkoopt June 23, 2026 04:28
@adrianreber

adrianreber commented Jun 27, 2026

Copy link
Copy Markdown
Member

@migueldiascosta any reasons this is still a draft? Are you still working on it?

@migueldiascosta migueldiascosta marked this pull request as ready for review June 27, 2026 16:04
@migueldiascosta

migueldiascosta commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

sorry, forgot about it

middelkoopt
middelkoopt requested changes Jul 9, 2026
View reviewed changes
Comment thread docs/install/templates/provisioner/warewulf/deploy-add-nodes.md.j2 Outdated
@middelkoopt

middelkoopt commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Perfect, before can merge, can you rebase it (if needed) and squash those two commits. You also need to do a signed-off-by for the DCO - see https://github.com/openhpc/ohpc/wiki/Contributions

@migueldiascosta
add note about naming of IB interface to the documentation about addi…
34ad9e7 
…ng nodes using warewulf

Co-authored-by: Timothy Middelkoop <tmiddelkoop@internet2.edu>

Signed-off-by: Miguel Dias Costa <migueldiascosta@gmail.com>
@migueldiascosta migueldiascosta force-pushed the update_ipoib_node_docs branch from 47c31e6 to 34ad9e7 Compare July 9, 2026 19:43
middelkoopt
middelkoopt approved these changes Jul 9, 2026
View reviewed changes

@middelkoopt middelkoopt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -thanks for the commit updates.

@middelkoopt middelkoopt merged commit 30a27e1 into openhpc:4.x Jul 9, 2026
24 checks passed
@middelkoopt

middelkoopt commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Merged thanks for the work on this - do you mind doing it for the 3.x branch as well (cherry-pick)?

@migueldiascosta migueldiascosta mentioned this pull request Jul 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@middelkoopt middelkoopt middelkoopt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@migueldiascosta @adrianreber @middelkoopt