fix enter key press in textfield#321
Open
vaneck237 wants to merge 1 commit into
Open
Conversation
|
This was referenced May 24, 2026
delcroip
approved these changes
May 26, 2026
Member
delcroip
left a comment
delcroip
left a comment
There was a problem hiding this comment.
i have no idea of that second sonarCloud, by memory state is always use like that
zikani03
requested changes
May 26, 2026
| this.fetchEnabled = props.modulesManager.getConf("fe-core", "shouldFetchInitially", true); | ||
| } | ||
| componentDidMount() { | ||
| document.addEventListener("keypress", this.handleEnter); |
Contributor
There was a problem hiding this comment.
Perhaps this should be handled via a ref on the element rather than being a document/page wide handler??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Search not working when tap enter key in textfield
Type of Change
Related Issue(s) / Task(s)
Demo
vid-git.mov
Checklist