Skip to content

Commit 274261b

Browse files
fix: align findMessageList params and return type across JS and native bridges (#99)
- iOS: change `findMessageList` bridge param type from `NSDictionary` to `NSArray` - Android: change `findMessageList` bridge param type from `ReadableMap` to `ReadableArray` - JS: fix `findMessageList` return type from `MessageItem[]` to `SearchMessageResult`
1 parent 573ccfc commit 274261b

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

android/src/main/java/com/openimsdkrn/OpenImSdkRnModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -610,8 +610,8 @@ public void getConversationIDBySessionType(ReadableMap options, String operation
610610
}
611611

612612
@ReactMethod
613-
public void findMessageList(ReadableMap findOptions, String operationID, Promise promise) {
614-
Open_im_sdk.findMessageList(new BaseImpl(promise), operationID, map2string(findOptions));
613+
public void findMessageList(ReadableArray findOptions, String operationID, Promise promise) {
614+
Open_im_sdk.findMessageList(new BaseImpl(promise), operationID, findOptions.toString());
615615
}
616616

617617
@ReactMethod

ios/OpenImSdkRn.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,7 @@ - (NSArray *)parseJsonStr2Array:(NSString *)jsonStr {
704704
Open_im_sdkSendMessageNotOss(proxy, operationID, [message json], recvID, groupID, [offlinePushInfo json], isOnlineOnly);
705705
}
706706

707-
RCT_EXPORT_METHOD(findMessageList:(NSDictionary *)findOptions operationID:(NSString *)operationID resolver:(RCTPromiseResolveBlock)resolver rejecter:(RCTPromiseRejectBlock)rejecter) {
707+
RCT_EXPORT_METHOD(findMessageList:(NSArray *)findOptions operationID:(NSString *)operationID resolver:(RCTPromiseResolveBlock)resolver rejecter:(RCTPromiseRejectBlock)rejecter) {
708708
RNCallbackProxy *proxy = [[RNCallbackProxy alloc] initWithCallback:resolver rejecter:rejecter];
709709
NSString *findOptionsJson = [findOptions json];
710710

src/OpenIMSDK.native.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ export interface NativeOpenIMSDKInterface {
484484
findMessageList: (
485485
params: FindMessageParams[],
486486
operationID: string
487-
) => Promise<MessageItem[]>;
487+
) => Promise<SearchMessageResult>;
488488
insertGroupMessageToLocalStorage: (
489489
params: InsertGroupMsgParams,
490490
operationID: string

0 commit comments

Comments
 (0)