Skip to content

8385815: [CRaC] Fix aarch64 failing testcases#321

Open
jankratochvil wants to merge 24 commits into
openjdk:cracfrom
jankratochvil:8385815
Open

8385815: [CRaC] Fix aarch64 failing testcases#321
jankratochvil wants to merge 24 commits into
openjdk:cracfrom
jankratochvil:8385815

Conversation

@jankratochvil

@jankratochvil jankratochvil commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

test/jdk/jdk/crac/CPUFeatures/SimpleCPUFeaturesTest.java
test/jdk/jdk/crac/engine/CheckCPUFeaturesTest.java

It needs some updates for the new CPU Features support.



Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8385815: [CRaC] Fix aarch64 failing testcases (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/321/head:pull/321
$ git checkout pull/321

Update a local copy of the PR:
$ git checkout pull/321
$ git pull https://git.openjdk.org/crac.git pull/321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 321

View PR using the GUI difftool:
$ git pr show -t 321

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/321.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 2, 2026

Copy link
Copy Markdown

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 2, 2026

Copy link
Copy Markdown

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8385815: [CRaC] Fix aarch64 failing testcases

Reviewed-by: tpushkin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the crac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TimPushkin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2026
@mlbridge

mlbridge Bot commented Jun 2, 2026

Copy link
Copy Markdown

@jankratochvil

Copy link
Copy Markdown
Contributor Author

The failed CI is a false positive:

Comment thread src/hotspot/cpu/aarch64/vm_version_aarch64.cpp Outdated
@TimPushkin TimPushkin changed the title 8385815: CRaC: Fix aarch64 failing testcases 8385815: [CRaC] Fix aarch64 failing testcases Jun 3, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2026
@jankratochvil

Copy link
Copy Markdown
Contributor Author

With upstream CRIU it somehow does not work now:

+ bin/java -XX:CRaCCheckpointTo=cr -XX:+ShowCPUFeatures -XX:CRaCEngine=criuengine -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000 CPUFeaturesAWS
This machine's CPU features are: -XX:CPUFeatures=0xe14e1b9dfdfbff,0xfcc0000000000000
CPU features being used are: -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000
Original environment variable: GLIBC_TUNABLES=glibc.pthread.rseq=0
Re-exec of java with new environment variable: GLIBC_TUNABLES=glibc.pthread.rseq=0:glibc.cpu.hwcaps=,-ERMS,-AVX512F,-AVX512CD,-AVX512BW,-AVX512DQ,-AVX512VL
This machine's CPU features are: -XX:CPUFeatures=0xe14e1b9dfdfbff,0xfcc0000000000000
CPU features being used are: -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000
CPUFeaturesCheck 0
CPUFeaturesCheck 1
+ set +e
+ bin/jcmd CPUFeaturesAWS JDK.checkpoint
CPUFeaturesCheck 2
CPUFeaturesCheck 3
CPUFeaturesCheck 4
CPUFeaturesCheck 5
CPUFeaturesCheck 6
CPUFeaturesCheck 7
Could not find any processes matching : 'CPUFeaturesAWS'
+ wait 2084
CPUFeaturesCheck 8
CPUFeaturesCheck 9
...
CPUFeaturesCheck 367
CPUFeaturesCheck 368
CPUFeaturesCheck 369
...

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2026
@jankratochvil jankratochvil marked this pull request as draft June 8, 2026 19:37
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2026
Comment thread src/hotspot/cpu/x86/vm_version_x86.hpp
@TimPushkin TimPushkin mentioned this pull request Jun 12, 2026
2 tasks
Comment thread src/hotspot/cpu/aarch64/vm_version_aarch64.cpp Outdated
Comment thread test/jdk/jdk/crac/CPUFeatures/CPUFeaturesAWS.sh Outdated
@jankratochvil

Copy link
Copy Markdown
Contributor Author

Known false positive failures:

@jankratochvil jankratochvil marked this pull request as ready for review July 4, 2026 08:39
@jankratochvil jankratochvil marked this pull request as draft July 4, 2026 08:39
@jankratochvil

Copy link
Copy Markdown
Contributor Author

CPUFeaturesAWS.sh has been tested on x86_64 and aarch64.

@jankratochvil jankratochvil marked this pull request as ready for review July 5, 2026 08:32
@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2026
@TimPushkin TimPushkin self-requested a review July 6, 2026 11:13
Comment thread src/hotspot/share/runtime/vm_features.inline.hpp
Comment thread src/hotspot/share/runtime/vm_features.inline.hpp
Comment thread src/hotspot/share/runtime/vm_features.inline.hpp Outdated
Comment thread src/hotspot/share/runtime/vm_features.inline.hpp
Comment thread test/jdk/jdk/crac/engine/CheckCPUFeaturesTest.java
Comment thread src/hotspot/share/runtime/vm_features.inline.hpp
Co-authored-by: Timofei Pushkin <pushkin.td@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants