8358549: O(n²) time complexity in java.security.Provider.parseLegacy() method

[mcpowers]

https://bugs.openjdk.org/browse/JDK-8358549

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358549: O(n²) time complexity in java.security.Provider.parseLegacy() method (Enhancement - P5)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31792/head:pull/31792
$ git checkout pull/31792

Update a local copy of the PR:
$ git checkout pull/31792
$ git pull https://git.openjdk.org/jdk.git pull/31792/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31792

View PR using the GUI difftool:
$ git pr show -t 31792

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31792.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mpowers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcpowers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358549: O(n²) time complexity in java.security.Provider.parseLegacy() method

Reviewed-by: djelinski, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 141 new commits pushed to the master branch:

• 74f9b51: 8381809: Template Framework Library: add Float16Vector type
• 6e5bfcc: 8387764: G1: Let G1CollectedHeap::_summary_bytes_used use the Atomic API
• f264341: 8387490: G1: Dynamically creating worker threads exposes memory visibility race
• ... and 138 more: https://git.openjdk.org/jdk/compare/12d7e6186622506cb19aad0e3d9e9256531e2851...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mcpowers The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b11a1e20)

[seanjmullan]

Does the test fail if you don't remove the whitespace?

[mcpowers]

Yes.

[ExE-Boss]

Note that the old version would use an empty String when all of attrName was spaces.

Suggested change

	for (int pos = 0; pos < attrName.length(); pos++) {
	if (attrName.charAt(pos) != ' ') {
	if (pos > 0) {
	attrName = attrName.substring(pos);
	}
	break;
	}
	}
	int pos = 0;
	for (; pos < attrName.length(); pos++) {
	if (attrName.charAt(pos) != ' ') {
	break;
	}
	}
	if (pos > 0) {
	attrName = attrName.substring(pos);
	}