8387414: Insufficient feature gate in vm_version_x86 for UseKyberIntrinsics#31807
8387414: Insufficient feature gate in vm_version_x86 for UseKyberIntrinsics#31807danielogh wants to merge 2 commits into
Conversation
|
👋 Welcome back dskantz! A progress list of the required criteria for merging this PR into |
|
@danielogh This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 63 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@danielogh The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Webrevs
|
| StubRoutines::_kyber12To16 = generate_kyber12To16_avx512(this, _masm); | ||
| StubRoutines::_kyberBarrettReduce = generate_kyberBarrettReduce_avx512(this, _masm); | ||
| } | ||
| assert(VM_Version::supports_avx512vlbw(), "must at least support AVX-512 VLBW"); |
There was a problem hiding this comment.
Having an assert for this case is not common practice based on other stub generators.
|
/label add security |
|
@smemery Only the PR author and project Committers are allowed to modify labels on a PR. |
|
Thank you for these changes @danielogh. Could you please add the security label to this PR? |
|
/label add security |
|
@danielogh |
smemery
left a comment
smemery
left a comment
There was a problem hiding this comment.
Thank you for the update. LGTM.
|
The rest of security pre-integration tests have come back clean. |
3 participants
Tidying up of an insufficient and redundant feature gate. BW implies EVEX so the latter check is not needed, but the Kyber fallback path requires VL as well which isn't checked. VBMI implies VL and BW though. Testing: T1-2
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31807/head:pull/31807$ git checkout pull/31807Update a local copy of the PR:
$ git checkout pull/31807$ git pull https://git.openjdk.org/jdk.git pull/31807/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31807View PR using the GUI difftool:
$ git pr show -t 31807Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31807.diff
Using Webrev
Link to Webrev Comment