8366342: Key generator and key pair generator tests skipping, but showing as passed#3224
8366342: Key generator and key pair generator tests skipping, but showing as passed#3224tkiriyama wants to merge 1 commit into
Conversation
|
👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Hi all,
I will backport JDK-8366342 from JDK 26 to JDK 11 to address an issue where, when specific PKCS#11 DES, ChaCha20 and DH capabilities were unavailable, tests would print a skipping message and return. This caused jtreg to misleadingly mark them as "Passed" because no explicit failure occurred. In other words, when PKCS#11 functionality was unavailable, the tests exited normally and were counted the same as successful tests, even though they did not actually verify any functionality.
This backport is equivalent to the fix applied in JDK 17.
There are additional, similar PKCS#11 test improvements in newer releases, but we plan to backport those to JDK 11 separately and in due course.
Thank you.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3224/head:pull/3224$ git checkout pull/3224Update a local copy of the PR:
$ git checkout pull/3224$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3224/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3224View PR using the GUI difftool:
$ git pr show -t 3224Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3224.diff
Using Webrev
Link to Webrev Comment