8386991: Insets are incorrectly set in newer Gnome versions

[satyenme]

Backporting 8386991: Insets are incorrectly set in newer Gnome versions from 17 to 11. Patch is clean.

The original backport of JDK-8305825 missed changes to src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java for JDK 17 and below. For 21 and above, JDK-8305825 reuses an if statement introduced by JDK-8267307. For 17 and below, since JDK-8267307 wasn't backported/present, a similar if statement should have been added just without the JDK-8267307-specific condition.

This leads to the SimpleTest.java test included on that JBS issue continuing to fail on Ubuntu 24.04.

This patch adds in the relevant code from the original JDK-8305825 patch to ensure the test passes and windows are rendered with the correct insets and size.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8386991 needs maintainer approval

Issue

• JDK-8386991: Insets are incorrectly set in newer Gnome versions (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3235/head:pull/3235
$ git checkout pull/3235

Update a local copy of the PR:
$ git checkout pull/3235
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3235

View PR using the GUI difftool:
$ git pr show -t 3235

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3235.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (beae5bb6)

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[satyenme]

/approval request for backport of "JDK-8386991: Insets are incorrectly set in newer Gnome versions" to 11

This fix addresses incorrect backport of JDK-8305825. Details of the missing code is summarized in the JBS issue description.

Testing: tier 1 and 2 tests and SimpleTest.java on original JBS issue.

Risk: minimal due to only affecting headful linux environments using mutter. Logically, code only adjusts inset size, with no expected change in functionality. Change is effectively already present in 17 and above.

[openjdk]

@satyenme
8386991: The approval request has been created successfully.