Skip to content

8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test#3236

Open
satyenme wants to merge 1 commit into
openjdk:masterfrom
satyenme:8334502
Open

8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test#3236
satyenme wants to merge 1 commit into
openjdk:masterfrom
satyenme:8334502

Conversation

@satyenme

@satyenme satyenme commented Jul 7, 2026

Copy link
Copy Markdown

Backporting JDK-8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test. Adjusts casting from time_t to int. Ran GHA Sanity Checks and previously failing gtest test (and full suite). Ran tier 1 and tier 2 tests. Patch is clean.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334502 needs maintainer approval

Issue

  • JDK-8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3236/head:pull/3236
$ git checkout pull/3236

Update a local copy of the PR:
$ git checkout pull/3236
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3236

View PR using the GUI difftool:
$ git pr show -t 3236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3236.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 7, 2026

Copy link
Copy Markdown

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport d41d2a7a82cb6eff17396717e2e14139ad8179ba 8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test Jul 7, 2026
@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 7, 2026
@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 7, 2026
@mlbridge

mlbridge Bot commented Jul 7, 2026

Copy link
Copy Markdown

Webrevs

@satyenme

satyenme commented Jul 7, 2026

Copy link
Copy Markdown
Author

/approval request for backport of "JDK-8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test". This fix addresses iso8601_utctime_test gtest failing by using an int type instead of a time_t type.

Testing: tier 1 and 2 tests and gtest suite.

Risk: low-ish. Touches hotspot code, but only iso8601_time. Logically, the two variables adjusted will never have a value greater than bounds of the int type, so functionality is preserved. Change is effectively already present in 24 and above.

@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

@satyenme
8334502: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant