8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test#3236
8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test#3236satyenme wants to merge 1 commit into
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of "JDK-8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test". This fix addresses iso8601_utctime_test gtest failing by using an int type instead of a time_t type. Testing: tier 1 and 2 tests and gtest suite. Risk: low-ish. Touches hotspot code, but only |
Backporting JDK-8334502: gtest/GTestWrapper.java fails on armhf due to LogDecorations.iso8601_utctime_test. Adjusts casting from time_t to int. Ran GHA Sanity Checks and previously failing gtest test (and full suite). Ran tier 1 and tier 2 tests. Patch is clean.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3236/head:pull/3236$ git checkout pull/3236Update a local copy of the PR:
$ git checkout pull/3236$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3236/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3236View PR using the GUI difftool:
$ git pr show -t 3236Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3236.diff
Using Webrev
Link to Webrev Comment