Skip to content

8283562: JDK-8282306 breaks gtests on zero#3237

Open
satyenme wants to merge 1 commit into
openjdk:masterfrom
satyenme:8283562
Open

8283562: JDK-8282306 breaks gtests on zero#3237
satyenme wants to merge 1 commit into
openjdk:masterfrom
satyenme:8283562

Conversation

@satyenme

@satyenme satyenme commented Jul 7, 2026

Copy link
Copy Markdown

Backporting JDK-8283562: JDK-8282306 breaks gtests on zero. Fixes test by skipping on platforms where we expect/know os::current_frame() will be zero (such as armv7). Trivial backport, only touches test code and adds additional disabling condition.



Progress

  • Change must not contain extraneous whitespace
  • JDK-8283562 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8283562: JDK-8282306 breaks gtests on zero (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3237/head:pull/3237
$ git checkout pull/3237

Update a local copy of the PR:
$ git checkout pull/3237
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3237

View PR using the GUI difftool:
$ git pr show -t 3237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3237.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 7, 2026

Copy link
Copy Markdown

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 78ef2fdef68c5161c8875296e9479026ac89743a 8283562: JDK-8282306 breaks gtests on zero Jul 7, 2026
@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 7, 2026
@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 7, 2026
@mlbridge

mlbridge Bot commented Jul 7, 2026

Copy link
Copy Markdown

Webrevs

@satyenme

satyenme commented Jul 7, 2026

Copy link
Copy Markdown
Author

/approval request for backport of "8283562: JDK-8282306 breaks gtests on zero". JDK-8282306 introduced os.is_first_C_frame_vm, but that breaks on zero since the test relies on os::current_frame(), which on all zero platforms is almost empty. This change skips the test on those platforms.

Testing: tier 1 and 2 tests and gtest suite.

Risk: low/almost none. Only touches test code, adding an exclude condition for the is_first_C_frame test. Essentially a trivial fix.

@openjdk

openjdk Bot commented Jul 7, 2026

Copy link
Copy Markdown

@satyenme
8283562: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jul 7, 2026
@parttimenerd

Copy link
Copy Markdown
Contributor

Could you please explain why you would be skipping the test on all JDK zero builds? Does this test fail for example on Linux amd64 zero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants