8283562: JDK-8282306 breaks gtests on zero#3237
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of "8283562: JDK-8282306 breaks gtests on zero". JDK-8282306 introduced os.is_first_C_frame_vm, but that breaks on zero since the test relies on os::current_frame(), which on all zero platforms is almost empty. This change skips the test on those platforms. Testing: tier 1 and 2 tests and gtest suite. Risk: low/almost none. Only touches test code, adding an exclude condition for the |
|
Could you please explain why you would be skipping the test on all JDK zero builds? Does this test fail for example on Linux amd64 zero? |
Backporting JDK-8283562: JDK-8282306 breaks gtests on zero. Fixes test by skipping on platforms where we expect/know os::current_frame() will be zero (such as armv7). Trivial backport, only touches test code and adds additional disabling condition.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3237/head:pull/3237$ git checkout pull/3237Update a local copy of the PR:
$ git checkout pull/3237$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3237/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3237View PR using the GUI difftool:
$ git pr show -t 3237Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3237.diff
Using Webrev
Link to Webrev Comment