8376185: NoSuchFieldError thrown after a record with type annotation retransformed#2900
8376185: NoSuchFieldError thrown after a record with type annotation retransformed#2900jpbempel wants to merge 2 commits into
Conversation
|
👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request retransformation on a record with type annotation on a record component leads to a corrupted state in the JVM memory. Best cases we have an exception, worst cases a JVM crash. It is common to use type annotation like @NotNull on the record components. |
Webrevs
|
|
We see java/lang/instrument/RetransformRecordTypeAnn/TestRetransformRecord.java failing in 25 now. There is a bug open for this, please do a ProblemList change for this and backport that change. By the way, how did you test this if the test is failing? I.e. without noticeing? |
I was using latest jtreg, even for old JDK. |
|
First, there was a bug open in JBS. Before you backport, you should check all bugs that are linked to the JBS issue. https://bugs.openjdk.org/browse/JDK-8369488 is one of the changes that determines the jtreg to be used. |
fix class case fix classfile version
Hi all,
This pull request contains a backport of commit 0c60c9ca from the openjdk/jdk repository.
The commit being backported was authored by Jean-Philippe Bempel on 25 Mar 2026 and was reviewed by Serguei Spitsyn and David Holmes.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2900/head:pull/2900$ git checkout pull/2900Update a local copy of the PR:
$ git checkout pull/2900$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2900/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2900View PR using the GUI difftool:
$ git pr show -t 2900Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2900.diff
Using Webrev
Link to Webrev Comment