8346463: Add test coverage for deploying the default provider as a module#2942
Open
rm-gh-8 wants to merge 1 commit into
Open
8346463: Add test coverage for deploying the default provider as a module#2942rm-gh-8 wants to merge 1 commit into
rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
Bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
Bot
added
the
backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8346463: Add test coverage for deploying the default provider as a module.
This PR refactors java.nio.file.spi tests to use a module structure and migrates SetDefaultProvider from TestNG to JUnit.
This PR isn't clean due to a conflict in the copyright header in Main.java, and the merge conflict in SetDefaultProvider.java needed to be manually resolved to resemble the Java 25 version because of skipped commits that don't apply to Java 21 (e.g., JEP 468).
For parity with Oracle JDK. Already backported to 25.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/net/UnixDomainSocketAddress/AddressTest.java
make test TEST=test/jdk/java/nio/file/spi/SetDefaultProvider.java
make test TEST=test/jdk/java/nio/file/spi/TestDelegation.java
Results:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
windows-x64-specific-3-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
macos-aarch64-specific-3-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-x64-specific-3-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-aarch64-specific-3-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2942/head:pull/2942$ git checkout pull/2942Update a local copy of the PR:
$ git checkout pull/2942$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2942/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2942View PR using the GUI difftool:
$ git pr show -t 2942Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2942.diff
Using Webrev
Link to Webrev Comment