Skip to content

8342442: Static ACVP sample tests#2945

Open
GoeLin wants to merge 1 commit into
openjdk:masterfrom
GoeLin:gbp_8342442
Open

8342442: Static ACVP sample tests#2945
GoeLin wants to merge 1 commit into
openjdk:masterfrom
GoeLin:gbp_8342442

Conversation

@GoeLin

@GoeLin GoeLin commented Jun 24, 2026

Copy link
Copy Markdown
Member

I backport this for parity with 21.0.13-oracle.

Ran Launcher.java with the following settings succesfully:
-Dtest.acvp.alg=SHA2-256 -Dtest.acvp.data=.../gen-val/json-files/SHA2-256-1.0/
-Dtest.acvp.alg=SHA2-224 -Dtest.acvp.data=.../gen-val/json-files/SHA2-224-1.0/
-Dtest.acvp.alg=SHA3-256 -Dtest.acvp.data=.../gen-val/json-files/SHA3-256-2.0/
-Dtest.acvp.alg=SHA3-224 -Dtest.acvp.data=.../gen-val/json-files/SHA3-224-2.0/

Other test passes, too.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8342442 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8342442: Static ACVP sample tests (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2945/head:pull/2945
$ git checkout pull/2945

Update a local copy of the PR:
$ git checkout pull/2945
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2945/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2945

View PR using the GUI difftool:
$ git pr show -t 2945

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2945.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 24, 2026

Copy link
Copy Markdown

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 24, 2026

Copy link
Copy Markdown

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342442: Static ACVP sample tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0cda7c9: 8247690: RunTest does not support running of JTREG manual tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title backport f400896822c2704d8e7c66afc1efa8a4fa91acb6 8342442: Static ACVP sample tests Jun 24, 2026
@openjdk

openjdk Bot commented Jun 24, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 24, 2026
@openjdk

openjdk Bot commented Jun 24, 2026

Copy link
Copy Markdown

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 24, 2026
@mlbridge

mlbridge Bot commented Jun 24, 2026

Copy link
Copy Markdown

Webrevs

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant