8342442: Static ACVP sample tests#2945
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
I backport this for parity with 21.0.13-oracle.
Ran Launcher.java with the following settings succesfully:
-Dtest.acvp.alg=SHA2-256 -Dtest.acvp.data=.../gen-val/json-files/SHA2-256-1.0/
-Dtest.acvp.alg=SHA2-224 -Dtest.acvp.data=.../gen-val/json-files/SHA2-224-1.0/
-Dtest.acvp.alg=SHA3-256 -Dtest.acvp.data=.../gen-val/json-files/SHA3-256-2.0/
-Dtest.acvp.alg=SHA3-224 -Dtest.acvp.data=.../gen-val/json-files/SHA3-224-2.0/
Other test passes, too.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2945/head:pull/2945$ git checkout pull/2945Update a local copy of the PR:
$ git checkout pull/2945$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2945/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2945View PR using the GUI difftool:
$ git pr show -t 2945Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2945.diff
Using Webrev
Link to Webrev Comment