Skip to content

8382063: Jtreg test javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java fails#2949

Open
ArnoZeller wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-ArnoZeller-a47f3620-master
Open

8382063: Jtreg test javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java fails#2949
ArnoZeller wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-ArnoZeller-a47f3620-master

Conversation

@ArnoZeller

@ArnoZeller ArnoZeller commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

I would like to backport this test only change as we see failures in our regression tests.
Low risk - test only change.



Progress

  • JDK-8382063 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8382063: Jtreg test javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java fails (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2949/head:pull/2949
$ git checkout pull/2949

Update a local copy of the PR:
$ git checkout pull/2949
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2949/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2949

View PR using the GUI difftool:
$ git pr show -t 2949

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2949.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 29, 2026

Copy link
Copy Markdown

👋 Welcome back azeller! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@ArnoZeller This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382063: Jtreg test javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5f1331a: 8371893: [macOS] use dead_strip linker option to reduce binary size
  • 0dceebb: 8372615: Many container tests fail when running rootless on cgroup v1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport a47f3620f2cae26e2e3f3642bd26871fdd02fddb 8382063: Jtreg test javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java fails Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ @ArnoZeller This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

@ArnoZeller

Copy link
Copy Markdown
Contributor Author

/approval request I backport this to fix a failure we see in our test environment.
No risk, test only change.
Applies clean and passes our tests.

@openjdk

openjdk Bot commented Jul 1, 2026

Copy link
Copy Markdown

@ArnoZeller
8382063: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 1, 2026
@ArnoZeller

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Jul 1, 2026
@openjdk

openjdk Bot commented Jul 1, 2026

Copy link
Copy Markdown

@ArnoZeller
Your change (at version 4910981) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

1 participant