8371164: ArrayList.addAll() optimizations#542
8371164: ArrayList.addAll() optimizations#542olivergillespie wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
phohensee
left a comment
There was a problem hiding this comment.
Copyright date in ArrayList.java should be 2025, not 2026. There should be no copyright date update in Collections.java and MOAT.java.
Thanks. Why is that? Because the copyright is connected to the original contribution, not the backport? |
|
The rule is that copyright update happens only if the update is in the original commit. Reason as I understand it is that makes later updates more likely to be clean. |
|
|
|
/approval request Performance improvement in core class. Some risk due to high exposure, but has been in tip for 6 months, and in 26 since release with no reported issues, and it's quite a simple isolated change. Backport is effectively clean. |
|
@olivergillespie |
Hi all,
This pull request contains a backport of commit aeea8497 from the openjdk/jdk repository.
The commit being backported was authored by John Engebretson on 18 Nov 2025 and was reviewed by Stuart Marks and Oli Gillespie.
Almost clean, just a trivial conflict in the MOAT buglist (upstream has one extra bug mentioned). Plus copyright years.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/542/head:pull/542$ git checkout pull/542Update a local copy of the PR:
$ git checkout pull/542$ git pull https://git.openjdk.org/jdk25u-dev.git pull/542/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 542View PR using the GUI difftool:
$ git pr show -t 542Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/542.diff
Using Webrev
Link to Webrev Comment