Skip to content

8371164: ArrayList.addAll() optimizations#542

Open
olivergillespie wants to merge 2 commits intoopenjdk:masterfrom
olivergillespie:backport-olivergillespie-aeea8497-master
Open

8371164: ArrayList.addAll() optimizations#542
olivergillespie wants to merge 2 commits intoopenjdk:masterfrom
olivergillespie:backport-olivergillespie-aeea8497-master

Conversation

@olivergillespie
Copy link
Copy Markdown

@olivergillespie olivergillespie commented May 1, 2026

Hi all,

This pull request contains a backport of commit aeea8497 from the openjdk/jdk repository.

The commit being backported was authored by John Engebretson on 18 Nov 2025 and was reviewed by Stuart Marks and Oli Gillespie.

Almost clean, just a trivial conflict in the MOAT buglist (upstream has one extra bug mentioned). Plus copyright years.

Thanks!



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371164 needs maintainer approval

Issue

  • JDK-8371164: ArrayList.addAll() optimizations (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/542/head:pull/542
$ git checkout pull/542

Update a local copy of the PR:
$ git checkout pull/542
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 542

View PR using the GUI difftool:
$ git pr show -t 542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/542.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 1, 2026

👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 1, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport aeea8497562aabda12f292ad93c9f0f6935cc842 8371164: ArrayList.addAll() optimizations May 1, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 1, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 1, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 1, 2026

Webrevs

Copy link
Copy Markdown
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright date in ArrayList.java should be 2025, not 2026. There should be no copyright date update in Collections.java and MOAT.java.

@olivergillespie
Copy link
Copy Markdown
Author

Copyright date in ArrayList.java should be 2025, not 2026. There should be no copyright date update in Collections.java and MOAT.java.

Thanks. Why is that? Because the copyright is connected to the original contribution, not the backport?

@phohensee
Copy link
Copy Markdown
Member

The rule is that copyright update happens only if the update is in the original commit. Reason as I understand it is that makes later updates more likely to be clean.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

⚠️ @olivergillespie This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@olivergillespie
Copy link
Copy Markdown
Author

/approval request Performance improvement in core class. Some risk due to high exposure, but has been in tip for 6 months, and in 26 since release with no reported issues, and it's quite a simple isolated change. Backport is effectively clean.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 8, 2026

@olivergillespie
8371164: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants