Skip to content

8348862: runtime/ErrorHandling/CreateCoredumpOnCrash fails on Windows aarch64#637

Open
raneashay wants to merge 6 commits into
openjdk:masterfrom
openjdk-bots:backport-raneashay-f4209dff-master
Open

8348862: runtime/ErrorHandling/CreateCoredumpOnCrash fails on Windows aarch64#637
raneashay wants to merge 6 commits into
openjdk:masterfrom
openjdk-bots:backport-raneashay-f4209dff-master

Conversation

@raneashay

@raneashay raneashay commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The following tests fail without this patch:

serviceability/sa/ClhsdbPstack.java
serviceability/sa/ClhsdbPmap.java
serviceability/sa/ClhsdbCDSCore.java
serviceability/sa/ClhsdbFindPC.java#xcomp-core

I couldn't force-push to this branch to remove commits that I had previously added in a different PR for the same branch, so I git-reverted them instead.



Progress

  • JDK-8348862 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348862: runtime/ErrorHandling/CreateCoredumpOnCrash fails on Windows aarch64 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/637/head:pull/637
$ git checkout pull/637

Update a local copy of the PR:
$ git checkout pull/637
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 637

View PR using the GUI difftool:
$ git pr show -t 637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/637.diff

Using Webrev

Link to Webrev Comment

duke and others added 5 commits June 23, 2026 18:52
Newer versions of armasm64 seem to be more lenient so that might be why we don't see this error when building this same code in JDK tip.
This is to prevent parsing errors on older versions of the armasm64
assembler.
@bridgekeeper

bridgekeeper Bot commented Jun 29, 2026

Copy link
Copy Markdown

👋 Welcome back arane! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@raneashay raneashay changed the title Backport raneashay f4209dff master 8348862: runtime/ErrorHandling/CreateCoredumpOnCrash fails on Windows aarch64 Jun 29, 2026
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@raneashay raneashay changed the title 8348862: runtime/ErrorHandling/CreateCoredumpOnCrash fails on Windows aarch64 Backport f4209dff3ba14ccbdc0846d9bfcc62688361b6d5 Jun 29, 2026
@openjdk openjdk Bot changed the title Backport f4209dff3ba14ccbdc0846d9bfcc62688361b6d5 8348862: runtime/ErrorHandling/CreateCoredumpOnCrash fails on Windows aarch64 Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ @raneashay This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

@raneashay

Copy link
Copy Markdown
Contributor Author

/approval request This patch fixes the handling of exceptions, which in turn fixes the execution of several tests in serviceability/sa/Clhsdb*.

@openjdk

openjdk Bot commented Jun 30, 2026

Copy link
Copy Markdown

@raneashay
8348862: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant