Skip to content

8368520: TLS 1.3 KeyUpdate fails with SunPKCS11 provider#639

Closed
GoeLin wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-GoeLin-56baf64a-master
Closed

8368520: TLS 1.3 KeyUpdate fails with SunPKCS11 provider#639
GoeLin wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-GoeLin-56baf64a-master

Conversation

@GoeLin

@GoeLin GoeLin commented Jun 29, 2026

Copy link
Copy Markdown
Member

I backport this as part of the larger cipher backport effort.



Progress

  • JDK-8368520 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368520: TLS 1.3 KeyUpdate fails with SunPKCS11 provider (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/639/head:pull/639
$ git checkout pull/639

Update a local copy of the PR:
$ git checkout pull/639
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 639

View PR using the GUI difftool:
$ git pr show -t 639

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/639.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 29, 2026

Copy link
Copy Markdown

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368520: TLS 1.3 KeyUpdate fails with SunPKCS11 provider

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport 56baf64ada04f233fbfe4e0cd033c86183e22015 8368520: TLS 1.3 KeyUpdate fails with SunPKCS11 provider Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 29, 2026
@openjdk

openjdk Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 29, 2026
@mlbridge

mlbridge Bot commented Jun 29, 2026

Copy link
Copy Markdown

Webrevs

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 1, 2026
@GoeLin

GoeLin commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

/integrate

@openjdk

openjdk Bot commented Jul 1, 2026

Copy link
Copy Markdown

Going to push as commit 3b47a4e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • de3cb2f: 8361125: Fix typo in onTradAbsence
  • 1ddfb33: 8382063: Jtreg test javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jul 1, 2026
@openjdk openjdk Bot closed this Jul 1, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 1, 2026
@openjdk

openjdk Bot commented Jul 1, 2026

Copy link
Copy Markdown

@GoeLin Pushed as commit 3b47a4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant