8325564: ComboBox popup does not correctly resize after update when on display by Ziad-Mid · Pull Request #2052 · openjdk/jfx

Ziad-Mid · 2026-01-26T21:36:46Z

Fixed popup size not changing to show more items or less when changing the number of items in ComboBox by adding a popupResize variable which triggers a request layout when there is change in items list.
Tested with the test app in bug and MonkeyTester.

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8325564: ComboBox popup does not correctly resize after update when on display (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2052/head:pull/2052
$ git checkout pull/2052

Update a local copy of the PR:
$ git checkout pull/2052
$ git pull https://git.openjdk.org/jfx.git pull/2052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2052

View PR using the GUI difftool:
$ git pr show -t 2052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2052.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-01-26T21:37:23Z

👋 Welcome back zelmidaoui! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-01-26T21:39:35Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

mlbridge · 2026-01-26T21:43:31Z

Webrevs

andy-goryachev-oracle

The fix does not look right: I don't think the new flag is needed, but instead the popup should be properly sized.

On top of that, the fixed code does not work: the first update shows a tiny popup where most of the area is covered with scrollbars, and the second update (after 2 seconds) still displays scrollbars. The scrollbars should not be there at all:

(on macOS retina, scale=2)

there is more: on an external monitor at scale=1, if I press the [Update] button then quickly click on the combo box, the popup is shown but very small, and it does not change:

andy-goryachev-oracle · 2026-01-27T18:23:58Z

        final Point2D p = getPrefPopupPosition();

        final Node popupContent = getPopupContent();
+        if (popupResize && popupContent instanceof Region) {


minor stylistic suggestion:

if (popupResize && popupContent instanceof Region r) { r.setMinSize(Region.USE_COMPUTED_SIZE, Region.USE_COMPUTED_SIZE); r.setPrefSize(Region.USE_COMPUTED_SIZE, Region.USE_COMPUTED_SIZE); }

also, look in sizePopup(), there is if (popupContent instanceof Region) { with the else clause which handles other cases.

Should any possible fix be in sizePopup() instead?

andy-goryachev-oracle · 2026-01-27T18:25:44Z

+        popupResize = false;
+    }
+
+    final void requestPopupLayout() {


misnomer: the name suggests it's a request, but in fact it does much more by calling

reconfigurePopup(); sizePopup();

andy-goryachev-oracle · 2026-01-27T18:47:26Z

/reviewers 2

openjdk · 2026-01-27T18:48:46Z

@andy-goryachev-oracle
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

andy-goryachev-oracle

The last change is a step in the right direction. Three issues:

Please merge the latest master, there was a change in sizePopup() which makes your code fail to compile. In general, it's a good idea to merge the latest master if your PR is long going or there was a change in a related area.
The reproducer shows the popup in the body of the first KeyFrame via comboBox.show();. Once the popup is shown, the second background update does not resize the popup and you see the scrollbars.
If you remove the comboBox.show(); line, the expectation is that the popup will not be shown, but it is, resulting in this:

Also, I've noticed the size of the popup control in the step 2 changes (also present in the master branch, so I guess it's expected)

andy-goryachev-oracle · 2026-01-29T20:14:05Z

@crschnick would you be able to review this PR?

andy-goryachev-oracle · 2026-02-02T23:09:58Z

Looks much better!

Two things:

please change the copyright year to 2026
noticed runLater() in recomputePopupLayout(), so I decided to apply CSS to the popup. You can use
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/bugs/ComboBox_PopupSize_8325564.java

On my primary retina display I get the scrollbars first time around. The scrollbars disappear on second showing:

.combo-box-popup > .list-view {
    -fx-padding: 100px
}

bridgekeeper · 2026-03-03T00:47:41Z

@Ziad-Mid This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2026-03-03T01:41:34Z

@Ziad-Mid This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

crschnick · 2026-03-03T06:45:23Z

@crschnick would you be able to review this PR?

Sorry, I didn't see this comment until now. I can take a look

Also what happened to bridgekeeper? That inactivity timeout looks wrong

crschnick · 2026-03-03T22:15:42Z

@andy-goryachev-oracle Can I still review this?

andy-goryachev-oracle · 2026-03-03T22:17:55Z

Let me check with @Ziad-Mid ...

kevinrushforth · 2026-03-03T22:28:14Z

Also what happened to bridgekeeper? That inactivity timeout looks wrong

Yes, this looks like a hiccup of some sort. The initial "inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes..." was correct. The "hey it's been 4 more weeks" auto-close one hour later was not. I'm reopening it.

andy-goryachev-oracle · 2026-03-03T22:31:08Z

... and I think @Ziad-Mid is still working on it, #2052 (comment) has not been addressed.

openjdk · 2026-03-04T15:12:30Z

@Ziad-Mid This pull request is already open

Ziad-Mid · 2026-03-04T15:13:06Z

... and I think @Ziad-Mid is still working on it, #2052 (comment) has not been addressed.

Yes, I still do

Ziad-Mid · 2026-04-22T12:46:13Z

/template append

openjdk · 2026-04-22T12:46:30Z

@Ziad-Mid The pull request template has been appended to the pull request body

andy-goryachev-oracle · 2026-04-22T19:16:50Z

So I think the problem identified in #2052 (comment) is still there.

I've updated the test not only to add items but also remove them (making the list smaller, just in case) - see the latest version
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/bugs/ComboBox_PopupSize_8325564.java

to reproduce,

click the combobox to show the popup,
click elsewhere to dismiss the popup
click update button
open the popup again

Expecting to see no scrollbar, but:

andy-goryachev-oracle

still see the scrollbar.

crschnick · 2026-04-29T08:21:21Z

In general I would say that if you have to rely on using Platform.runLater for some kind of layouting and size changes within a Control or Skin, the approach is usually not the right one. I would try to replace the runLater call with another implementation that fixes the issue as well somehow.

Ziad-Mid · 2026-05-06T20:20:08Z

Tested with latest test from Andy and it works.

crschnick · 2026-05-07T15:03:42Z

While fixing https://bugs.openjdk.org/browse/JDK-8338145, I found the cause to be the fact that the popup did not have the right size computed before the first show. That is why the fix calls sizePopup() twice. Maybe this issue is related and somehow eliminates the need to call sizePopup() twice?

Ziad-Mid and others added 3 commits January 15, 2026 21:46

Fixed ComboBox popup size not changing after update.

0074758

Merge branch 'openjdk:master' into 8325564.popupSize

8f84303

Merge branch 'openjdk:master' into 8325564.popupSize

cfb00a4

openjdk Bot added the rfr Ready for review label Jan 26, 2026

andy-goryachev-oracle suggested changes Jan 27, 2026

View reviewed changes

Removed 'popupResize' flag

c975fc5

andy-goryachev-oracle suggested changes Jan 29, 2026

View reviewed changes

Ziad-Mid and others added 2 commits January 30, 2026 13:32

Merge branch 'openjdk:master' into 8325564.popupSize

29a4d17

Fix scrollbar issue

9ed0cee

bridgekeeper Bot closed this Mar 3, 2026

kevinrushforth reopened this Mar 3, 2026

Ziad-Mid added 2 commits April 1, 2026 13:00

Merge branch 'openjdk:master' into 8325564.popupSize

735ae7d

Merge branch 'openjdk:master' into 8325564.popupSize

53e78f3

openjdk Bot removed the rfr Ready for review label Apr 22, 2026

openjdk Bot added the rfr Ready for review label Apr 22, 2026

andy-goryachev-oracle suggested changes Apr 22, 2026

View reviewed changes

Fixed Scrollbar issue with CSS

5cc062f

Conversation

Ziad-Mid commented Jan 26, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Uh oh!

bridgekeeper Bot commented Jan 26, 2026

Uh oh!

openjdk Bot commented Jan 26, 2026

Uh oh!

mlbridge Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

Uh oh!

andy-goryachev-oracle Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

andy-goryachev-oracle Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

andy-goryachev-oracle Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

andy-goryachev-oracle commented Jan 27, 2026

Uh oh!

openjdk Bot commented Jan 27, 2026

Uh oh!

andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

Uh oh!

andy-goryachev-oracle commented Jan 29, 2026

Uh oh!

andy-goryachev-oracle commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bridgekeeper Bot commented Mar 3, 2026

Uh oh!

bridgekeeper Bot commented Mar 3, 2026

Uh oh!

crschnick commented Mar 3, 2026

Uh oh!

crschnick commented Mar 3, 2026

Uh oh!

andy-goryachev-oracle commented Mar 3, 2026

Uh oh!

kevinrushforth commented Mar 3, 2026

Uh oh!

andy-goryachev-oracle commented Mar 3, 2026

Uh oh!

openjdk Bot commented Mar 4, 2026

Uh oh!

Ziad-Mid commented Mar 4, 2026

Uh oh!

Ziad-Mid commented Apr 22, 2026

Uh oh!

openjdk Bot commented Apr 22, 2026

Uh oh!

andy-goryachev-oracle commented Apr 22, 2026

Uh oh!

andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

Uh oh!

crschnick commented Apr 29, 2026

Uh oh!

Ziad-Mid commented May 6, 2026

Uh oh!

crschnick commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Ziad-Mid commented Jan 26, 2026 •

edited by openjdk Bot

Loading

mlbridge Bot commented Jan 26, 2026 •

edited

Loading

andy-goryachev-oracle commented Feb 2, 2026 •

edited

Loading