8382049: [TestBug] Multiple StubToolkit checks in JavaFX production code by Maran23 · Pull Request #2146 · openjdk/jfx

Maran23 · 2026-04-12T20:07:47Z

This PR removes all StubToolkit checks from JavaFX production code.
There are only a few.

Two notes:

Note 1: TableRowSkinBases DO_ANIMATIONS is now true for tests. It was not before due to a leak (as far as I could find when digging JDK-8120657). But I could not find any problem, even running all tests with -Xmx512m
Checking tests that trigger the affected code path and creating a heapdump after, I could not see anything weird:

Heapdump after TreeTableViewResizeTest:

Note 2: Now when the tests run in CI, JavaFX: using test.com.sun.javafx.pgstub.StubToolkit is now printed 12 times (probably the amount of Unit Test Threads):

If this is a problem, we can decide if we want to change the print code in Toolkit (in a follow-up).
-> Changed to System.out in this PR.

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8382049: [TestBug] Multiple StubToolkit checks in JavaFX production code (Enhancement - P4)

Reviewers

Andy Goryachev (@andy-goryachev-oracle - Reviewer)
Michael Strauß (@mstr2 - Reviewer)
Lukasz Kostyra (@lukostyra - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2146/head:pull/2146
$ git checkout pull/2146

Update a local copy of the PR:
$ git checkout pull/2146
$ git pull https://git.openjdk.org/jfx.git pull/2146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2146

View PR using the GUI difftool:
$ git pr show -t 2146

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2146.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-04-12T20:08:07Z

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-04-12T20:09:01Z

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382049: [TestBug] Multiple StubToolkit checks in JavaFX production code

Reviewed-by: angorya, mstrauss, lkostyra

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

c10ff9f: 8301283: Util methods for computing text/width height giving up some performance
6981fb4: 8383783: MediaQueryParser should reject query lists without comma separator
24f07a9: 8384522: Update libxml2 to 2.15.3
... and 25 more: https://git.openjdk.org/jfx/compare/6ddb2b2f76a2facfd9d1345787cfa4a6658b0412...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mlbridge · 2026-04-12T20:12:41Z

Webrevs

01: Full - Incremental (992cde61)
00: Full (87110347)

andy-goryachev-oracle · 2026-04-13T15:59:44Z

/reviewers 2

openjdk · 2026-04-13T16:02:54Z

@andy-goryachev-oracle
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

andy-goryachev-oracle · 2026-04-13T16:22:46Z

Re: TableRowSkinBases and DO_ANIMATIONS - there were quite a few memory leak fixes implemented recently (er, 2024), so enabling animations is likely to be ok (especially if it does not fail any headful CI runs).

Tickets in question:
https://bugs.openjdk.org/browse/JDK-8341687
https://bugs.openjdk.org/browse/JDK-8320232
https://bugs.openjdk.org/browse/JDK-8323543
https://bugs.openjdk.org/browse/JDK-8307538

Maran23 · 2026-04-13T17:07:45Z

Re: TableRowSkinBases and DO_ANIMATIONS - there were quite a few memory leak fixes implemented recently (er, 2024), so enabling animations is likely to be ok (especially if it does not fail any headful CI runs).

I had the same thought.
And if there is a problem only in the headless tests, we can still decide to disable the animations for headless tests with e.g. a System Property or similar.
But since other Controls also use Animations (Pagination, TitledPane, TabPane (Tab close)) and no issue there, I think this is fine.

andy-goryachev-oracle

I am running CI builds, will update on the result. the code changes look good.

andy-goryachev-oracle · 2026-04-13T17:34:12Z

Out CI runs are all green.

…ed in Java (looking at you, C++)

andy-goryachev-oracle

thank you! lgtm

bridgekeeper · 2026-05-12T11:25:51Z

@Maran23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

andy-goryachev-oracle · 2026-05-12T16:06:12Z

sorry for letting this PR auto-expire. please re-open.

andy-goryachev-oracle · 2026-05-20T21:54:59Z

@lukostyra could you be the second reviewer please?

lukostyra

LGTM. Ran both local and CI testing and everything looks good.

Maran23 · 2026-05-27T12:54:08Z

/integrate

openjdk · 2026-05-27T12:58:44Z

Going to push as commit 58a7bea.
Since your change was applied there have been 28 commits pushed to the master branch:

c10ff9f: 8301283: Util methods for computing text/width height giving up some performance
6981fb4: 8383783: MediaQueryParser should reject query lists without comma separator
24f07a9: 8384522: Update libxml2 to 2.15.3
... and 25 more: https://git.openjdk.org/jfx/compare/6ddb2b2f76a2facfd9d1345787cfa4a6658b0412...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-05-27T12:59:03Z

@Maran23 Pushed as commit 58a7bea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8382049: [TestBug] Multiple StubToolkit checks in JavaFX production code

8711034

Maran23 commented Apr 12, 2026

View reviewed changes

Comment thread modules/javafx.graphics/src/test/java/test/com/sun/javafx/pgstub/StubToolkit.java Outdated

openjdk Bot added the rfr Ready for review label Apr 12, 2026

andy-goryachev-oracle reviewed Apr 13, 2026

View reviewed changes

Comment thread modules/javafx.graphics/src/test/java/test/com/sun/javafx/pgstub/StubToolkit.java Outdated

Comment thread modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java

Use System.out, remove = null assignment which is thankfully not need…

992cde6

…ed in Java (looking at you, C++)

andy-goryachev-oracle approved these changes Apr 13, 2026

View reviewed changes

kevinrushforth self-requested a review April 14, 2026 15:59

mstr2 reviewed May 21, 2026

View reviewed changes

Comment thread modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java

mstr2 approved these changes May 27, 2026

View reviewed changes

openjdk Bot added the ready Ready to be integrated label May 27, 2026

lukostyra approved these changes May 27, 2026

View reviewed changes

openjdk Bot added the integrated Pull request has been integrated label May 27, 2026

openjdk Bot closed this May 27, 2026

openjdk Bot removed ready Ready to be integrated rfr Ready for review labels May 27, 2026

Maran23 mentioned this pull request Jun 16, 2026

8386698: PlatformUtil has unused fields and methods #2190

Closed

4 tasks

Maran23 deleted the stubtoolkit-leak-prod branch July 3, 2026 15:03

Uh oh!

Conversation

Maran23 commented Apr 12, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented Apr 12, 2026

Uh oh!

openjdk Bot commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mlbridge Bot commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

andy-goryachev-oracle commented Apr 13, 2026

Uh oh!

openjdk Bot commented Apr 13, 2026

Uh oh!

andy-goryachev-oracle commented Apr 13, 2026

Uh oh!

Maran23 commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

andy-goryachev-oracle commented Apr 13, 2026

Uh oh!

andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

Uh oh!

bridgekeeper Bot commented May 12, 2026

Uh oh!

andy-goryachev-oracle commented May 12, 2026

Uh oh!

andy-goryachev-oracle commented May 20, 2026

Uh oh!

Uh oh!

lukostyra left a comment

Choose a reason for hiding this comment

Uh oh!

Maran23 commented May 27, 2026

Uh oh!

openjdk Bot commented May 27, 2026

Uh oh!

openjdk Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Maran23 commented Apr 12, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Apr 12, 2026 •

edited

Loading

mlbridge Bot commented Apr 12, 2026 •

edited

Loading

Maran23 commented Apr 13, 2026 •

edited

Loading