8374804: ConditionalFeature media queries#2161
Conversation
|
👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
/reviewers 2 |
|
/csr |
|
@mstr2 has indicated that a compatibility and specification (CSR) request is needed for this pull request. @mstr2 please create a CSR request for issue JDK-8374804 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
|
This looks like a nice addition. I'll review the CSR, but I hope others will review the code. Reviewers: @andy-goryachev-oracle , ??? |
|
yes, it's in my review queue |
This PR adds the
-fx-supports-conditional-featuremedia query, which allows applications to adapt their stylesheets to different platforms with varying conditional feature support. Currently, the built-in themes use hard-coded logic to include or exclude conditional-feature stylesheets. The new media query allows us to potentially remove the hard-coded logic in the future, and gives third-party themes an API to query conditional feature support.Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2161/head:pull/2161$ git checkout pull/2161Update a local copy of the PR:
$ git checkout pull/2161$ git pull https://git.openjdk.org/jfx.git pull/2161/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2161View PR using the GUI difftool:
$ git pr show -t 2161Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2161.diff
Using Webrev
Link to Webrev Comment