Skip to content

8374804: ConditionalFeature media queries#2161

Open
mstr2 wants to merge 1 commit into
openjdk:masterfrom
mstr2:feature/conditional-feature-query
Open

8374804: ConditionalFeature media queries#2161
mstr2 wants to merge 1 commit into
openjdk:masterfrom
mstr2:feature/conditional-feature-query

Conversation

@mstr2
Copy link
Copy Markdown
Collaborator

@mstr2 mstr2 commented May 3, 2026

This PR adds the -fx-supports-conditional-feature media query, which allows applications to adapt their stylesheets to different platforms with varying conditional feature support. Currently, the built-in themes use hard-coded logic to include or exclude conditional-feature stylesheets. The new media query allows us to potentially remove the hard-coded logic in the future, and gives third-party themes an API to query conditional feature support.



Progress

  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8384139 to be approved
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

  • JDK-8374804: ConditionalFeature media queries (Enhancement - P4)
  • JDK-8384139: ConditionalFeature media queries (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2161/head:pull/2161
$ git checkout pull/2161

Update a local copy of the PR:
$ git checkout pull/2161
$ git pull https://git.openjdk.org/jfx.git pull/2161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2161

View PR using the GUI difftool:
$ git pr show -t 2161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2161.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 3, 2026

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 3, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Ready for review label May 3, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 3, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: rfr. This can be overridden with the /reviewers command.

@mstr2
Copy link
Copy Markdown
Collaborator Author

mstr2 commented May 3, 2026

/reviewers 2

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 3, 2026

@mstr2
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 3, 2026

Webrevs

@mstr2
Copy link
Copy Markdown
Collaborator Author

mstr2 commented May 3, 2026

/csr

@openjdk openjdk Bot added the csr Need approved CSR to integrate pull request label May 3, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 3, 2026

@mstr2 has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@mstr2 please create a CSR request for issue JDK-8374804 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@kevinrushforth
Copy link
Copy Markdown
Member

This looks like a nice addition. I'll review the CSR, but I hope others will review the code.

Reviewers: @andy-goryachev-oracle , ???

@andy-goryachev-oracle
Copy link
Copy Markdown
Contributor

yes, it's in my review queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

csr Need approved CSR to integrate pull request rfr Ready for review

Development

Successfully merging this pull request may close these issues.

3 participants